Repository navigation
Conversation
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the desktop shell privileged API confined to its own top-level frame and allow local live-view guests only at Browserbase's inspector routes. Bundle the preload so the shell can enable sandboxing; deny guest preloads, Node access, popups, unexpected navigation, and local device permissions. The shell CSP now permits only packaged scripts, and tab metadata is rendered with DOM properties rather than HTML interpolation.
Inline handlers have been replaced with listeners, live-view capability URLs are no longer logged by the renderer, and missing optional status-bar elements no longer interrupt connection-error handling.
Verification
npm run buildandtsc --noEmit -p tsconfig.jsonnode --test tests/security-url.test.cjsxvfb-run -a electron --no-sandbox tests/electron-security.cjswith Electron 45.3.2--no-sandbox, so OS sandbox enforcement is not verified.Screenshot: full application UI with a local synthetic viewer fixture; no live cloud session is represented.
Additional integration verification with the companion runtime, lifecycle, tab, and viewport changes applied: all 34 automated tests passed. The actual Electron app opened a real cloud Live View; a screenshot-only computer-use model completed a synthetic form in 14 actions, and an independent remote-state check confirmed the values. Reload preserved the tab/address and session, and app shutdown released the session. Pointer input targeted the desktop window; keyboard events targeted the embedded viewer. This Linux run still required
--no-sandbox.Combined validation: the mainline candidate containing #13–#18 and #20 passed builds, all 34 automated tests, and the high/critical advisory gate on Linux, macOS, and Windows. Cross-platform CI results.