Skip to content

Harden the experimental folder-sync desktop runtime - #21

Draft
shrey150 wants to merge 23 commits into
codex/desktop-audit-mirror-limitsfrom
codex/desktop-experimental-integration
Draft

shrey150 wants to merge 23 commits into
codex/desktop-audit-mirror-limitsfrom
codex/desktop-experimental-integration

Conversation

@shrey150

@shrey150 shrey150 commented Nov 13, 2026 •

Copy link
Copy Markdown

The experimental folder-sync release needs the desktop security and reliability fixes while preserving its separate utility-process mirror lifecycle. This adapts the mainline hardening to that release: isolate the desktop shell and Live View guests, authenticate optional local automation, redact session capabilities, release failed or closing sessions, keep tab identity stable, and size the remote viewport from the visible content area.

This draft is stacked on #19 and targets the experimental release path. It incorporates the changes proposed in #13–#18 and #20; those remain the smaller review units for mainline. The mirror starts before navigation, flushes before session release, and follows tab selection and reconnect. Its extra IPC handlers use the same sender checks, and managed mirror output uses owner-only POSIX permissions. Future tags containing a suffix are marked as prereleases.

Compatibility: local automation clients must read the per-launch token from the descriptor and send it as a bearer token. Development now requires Node.js 22.12 or newer. The application version remains unchanged; this PR does not publish a release.

Validation:

  • Startup regression covers closing the last window during either viewport await and reopening normally.
  • Atomic mirror output retries transient Windows destination locks with bounded backoff, preserving the existing file and cleaning temporary files. Tests cover recovery, persistent locks, unrelated errors, and POSIX behavior.
  • Full build and 70 regression tests pass, including the pinned ZIP reader and experimental mirror lifecycle.
  • Actual Electron security and viewport harnesses pass. The Linux test environment requires --no-sandbox, so these runs verify isolation settings and boundaries, not OS sandbox enforcement.
  • A real cloud mirror test passes utility-process CDP, changing frames and HTML/log output, exact download/upload bytes, tab selection, reconnect preservation, and graceful shutdown. The session reaches COMPLETED.
  • A screenshot-only computer-use agent completes a synthetic form through the actual Electron window in 16 actions. Shell reload preserves tab/address state and reuses the session; shutdown releases it.
  • The dependency audit reports zero high or critical advisories; six moderate development-tool advisories remain. Clean-install validation runs on Linux, macOS, and Windows in CI.

Actual experimental desktop window after the synthetic computer-use task:

Experimental desktop after the computer-use check

Final validation: clean installation, build, regression tests, and the high/critical advisory gate pass on Linux, macOS, and Windows. Cross-platform CI results.

@socket-security

socket-security Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedelectron-builder@​24.13.3 ⏵ 26.18.099 +110069 +198 +2100
Updatedelectron@​39.2.7 ⏵ 45.3.297 +4100 +7510098100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant