Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental folder-sync release needs the desktop security and reliability fixes while preserving its separate utility-process mirror lifecycle. This adapts the mainline hardening to that release: isolate the desktop shell and Live View guests, authenticate optional local automation, redact session capabilities, release failed or closing sessions, keep tab identity stable, and size the remote viewport from the visible content area.
This draft is stacked on #19 and targets the experimental release path. It incorporates the changes proposed in #13–#18 and #20; those remain the smaller review units for mainline. The mirror starts before navigation, flushes before session release, and follows tab selection and reconnect. Its extra IPC handlers use the same sender checks, and managed mirror output uses owner-only POSIX permissions. Future tags containing a suffix are marked as prereleases.
Compatibility: local automation clients must read the per-launch token from the descriptor and send it as a bearer token. Development now requires Node.js 22.12 or newer. The application version remains unchanged; this PR does not publish a release.
Validation:
--no-sandbox, so these runs verify isolation settings and boundaries, not OS sandbox enforcement.COMPLETED.Actual experimental desktop window after the synthetic computer-use task:
Final validation: clean installation, build, regression tests, and the high/critical advisory gate pass on Linux, macOS, and Windows. Cross-platform CI results.