Skip to content

Update Electron runtime and validate cross-platform builds - #13

Draft
shrey150 wants to merge 4 commits into
mainfrom
codex/desktop-audit-runtime
Draft

shrey150 wants to merge 4 commits into
mainfrom
codex/desktop-audit-runtime

Conversation

@shrey150

@shrey150 shrey150 commented Nov 13, 2026 •

Copy link
Copy Markdown

Desktop Browserbase currently packages Electron 39.2.7 and electron-builder 24.13.3. This updates to Electron 45.3.2 and electron-builder 26.18.0, refreshes the lockfile, and moves the development prerequisite to Node 22.12+ (CI uses Node 24).

Asset copying now uses Node's filesystem API so the build also works in Windows shells. A validation workflow checks builds on Linux, Windows, and macOS, and rejects high/critical npm advisories. Release build jobs use read-only permissions and explicitly disable electron-builder publishing; the final release job remains responsible for publication. Tags with prerelease suffixes, including -experimental, are marked as prereleases.

Verification

Command / flow Observed output Confidence / sufficiency
npm run build TypeScript, renderer bundle, and asset copy passed Compiles the upgraded toolchain on Linux
npm run pack -- --publish never Produced Linux unpacked Electron 45.3.2 app Packaging succeeds; macOS/Windows distribution still needs native CI
Inspect packaged ASAR Main entry, preload, renderer HTML/JS/CSS, and Playwright dependency present Required runtime assets included
Launch packaged app under Xvfb Renderer loaded and created a remote session; test session released Linux startup smoke, not proof of a completed interactive browser flow
npm audit --audit-level=high Exit 0; zero high/critical findings, down from 16 high and one critical Six moderate build-tool findings remain, all from the minimatch advisory chain
npm audit --omit=dev Zero findings Covers production npm dependencies; Electron is separately covered by the full audit

The remaining minimatch issue is in build-time tooling. Avoid forcing a major transitive override or downgrading electron-builder to satisfy npm's suggested fix; neither is established as compatible. No app version/tag is changed by this PR.

Combined validation: the mainline candidate containing #13–#18 and #20 passed builds, all 34 automated tests, and the high/critical advisory gate on Linux, macOS, and Windows. Cross-platform CI results.

@socket-security

socket-security Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedelectron-builder@​24.13.3 ⏵ 26.18.099 +110069 +198 +2100
Updatedelectron@​39.2.7 ⏵ 45.3.297 +4100 +7510098100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant