Skip to content

Keep session access credentials out of diagnostics - #14

Draft
shrey150 wants to merge 1 commit into
mainfrom
codex/desktop-safe-diagnostics
Draft

shrey150 wants to merge 1 commit into
mainfrom
codex/desktop-safe-diagnostics

Conversation

@shrey150

@shrey150 shrey150 commented Nov 13, 2026 •

Copy link
Copy Markdown

Stop writing Browserbase connection URLs, signed debug payloads, API error bodies, and visited-page URLs to main-process diagnostics. Session errors sent to the renderer now redact URLs and the configured API key while preserving useful error text.

E2E Test Matrix

Command / flow Observed output Confidence / sufficiency
npm run build:main && node --test tests/diagnostics.test.cjs 3 tests pass Synthetic API/session/debug secrets do not appear in logs; upstream error bodies are excluded; connection error messages and stacks are sanitized
Original packaged-app startup Confirmed session connection and Live View URLs appeared in startup output; test session immediately released Confirms the original exposure, without publishing credentials or live identifiers

This change covers main-process diagnostics. The separate renderer isolation patch removes renderer-side connection URL logging.

Combined validation: the mainline candidate containing #13–#18 and #20 passed builds, all 34 automated tests, and the high/critical advisory gate on Linux, macOS, and Windows. Cross-platform CI results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant