Repository navigation
Conversation
…ptions, a bare value option at the end and --platform are errors
…orm is vs again; tests only report stray files
Member
Author
|
Merged as part of #695 (3afaff3): #695 was stacked on this branch and its squash merge brought these commits into master, so rebased onto master this PR is empty. On master: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated cmdLine from 0.120.0 to 0.121.0 and PG GUI from 0.114.0 to 0.115.0
scripts/test_cmdline_args.sh <projectGenerator> <OF root> [platform]- 34 cases run from the macOS, Linux and Windows CI (scripts/*/test_cmdline.sh), so a value taken as the project path (#693) fails CI instead of generating a project somewhere else. After every case it checks that nothing new appeared at the OF root, inapps/orapps/myApps/.=/ separate values, short and long, relative and absolute-o, every value option separated (-a -D -P -s), path only, missing path, bare value option at the end, two paths, option after the path, the OF folder as the project, unknown platform, unknown option,--platformtypo, bad-o,--dryrunwrites nothing,-rfolder.frameworksuffix, duplicates,libX.tbd/-lX/libX/X, libs given to-f, kept on update, empty-f/--system-libs=remove them,+=lines in config.make, Xcode file refsFound while writing them, fixed here:
-p bogus-> exit 139, getTargetProject returned no project); nowUnknown platform, exit 64-pcrashed the same way: the host platform checked__WIN32__, which MSVC doesn't define, so it was empty; now_WIN32too, so it'svsagain--bogus-> exit 0); nowUnknown option, exit 64-p osxwith no project path made a project calledosx; a bare value option at the end now takes the value (missing project path, exit 64). Only-f/--frameworks/--system-libskeep meaning empty there--platform osx(typo of--platforms) was the long name of-i: printed the host platform and exited 0 without touching the project. Renamed to--getplatform, as--helpalready said../../examples/ ./projectGenerator) and the osx tests didn't check exit codes, so after Fix cmdLine placing projects into oF root with certain params #693 it failed without failing CIRun locally on macOS for osx / linux64 / vs, with the binary inside and outside an OF tree: 34 / 34 / 30 cases (vs has no config.make template, so no defines / version cases), 0 failures. Against the binary from before #693: 54 failures; against current master: the 4 fixed here.