Repository navigation
Conversation
…he path; only -p <platform> with no path is an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated cmdLine from 0.121.0 to 0.122.0 and PG GUI from 0.116.0 to 0.117.0
0.121.0 (#694, in master via #695) took a bare value option's next word even when it was the last argument, to catch
-p osxwith no project path. But an empty value right before the path is normal:scripts/ci/vs/pg_projects.sh):projectGenerator.exe -o"OF" -v -a"" -p"vs" -t"" "OF\examples\templates\emptyExample"-> after eval-t+ path ->{ "Template": ".../emptyExample" },Missing project path, exit 64. build-vs 2022 x64 / ARM64 / ARM64EC and build-cmake vs-x64 fail on every openFrameworks PR (e.g. https://github.com/openframeworks/openFrameworks/actions/runs/41310475024)-tthen the project path, same failureThe last argument is the project path again (as in 0.120.0). Only
-p <platform>/--platforms <platform>with nothing after it, where that word is a platform and not an existing folder, is still an error instead of making a project calledosx.New cases in
scripts/test_cmdline_args.sh: the CI command (-o"OF" -v -a"" -p"vs" -t"" path), a bare-tbefore the path (GUI),-a "" -t "" path. On the 0.121.0 master build these fail (exit 64); with this PR osx 37 / linux64 37 / vs 33 cases, 0 failures.