Skip to content

Frame store screenshots with storeframe - #760

Merged
andiwand merged 2 commits into
mainfrom
storeframe
Nov 14, 2026
Merged

andiwand merged 2 commits into
mainfrom
storeframe

Conversation

@andiwand

@andiwand andiwand commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

The screenshot framing script moved into its own package, storeframe (PyPI), shared by OpenDocument.ios, OpenDocument.droid and almucantar.

Changes

  • Delete scripts/frame-screenshots.py; the screenshots lane runs python3 -m storeframe frame fastlane/frames/frames.json … instead.
  • Add scripts/requirements.txt with storeframe==0.1.0 (pinned); the release workflow installs it instead of Pillow.
  • frames.json is unchanged except for "aliases": ["04-edit-lite"] on 04-edit. That mapping used to be hard-coded in the script.
  • Remove the bundled Nunito copy; storeframe ships the same font file.
  • Update the docs and comments that pointed at the old script.

Verification

  • Framed the real captures, replicated to every store locale and with a lite capture added, using the old script and storeframe 0.1.0 from PyPI. Both produced the same file names and sizes.
  • Android: 210 pictures, including a feature graphic in all 15 locales. The worst mean pixel difference is 0.17 out of 255. The Hindi, Japanese and Chinese headlines look the same as before.
  • scripts/store_screenshots.py --screenshots accepts the output. Its only complaint was the tablet lite capture, which my test data didn't include.
  • No emulator run yet. The next release screenshots job in CI is the real check.

andiwand and others added 2 commits November 14, 2026 15:14
The framing script moved into its own package, storeframe
(https://github.com/andiwand/storeframe), shared with OpenDocument.ios.
The lane now runs it on fastlane/frames/frames.json, feature graphics
included; the design file is unchanged apart from the 04-edit-lite alias,
which used to be hard-coded in the script. The font ships with the package,
so its copy here is gone. Hindi, Japanese and Chinese still need the Noto
fonts on the runner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FW6WZWfrDqfHDPiWY7fcMg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FW6WZWfrDqfHDPiWY7fcMg
@andiwand
andiwand merged commit 0ee1185 into main Nov 14, 2026
7 checks passed
@andiwand
andiwand deleted the storeframe branch November 14, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant