Repository navigation
Write the screenshot documents with the sampledoc package - #759
Merged
Merged
Conversation
The documents the store screenshots open were generated by a 2,200 line script that the iOS app carried a copy of. Both now take them from sampledoc (https://pypi.org/project/sampledoc/), pinned at 0.1.0 in scripts/requirements.txt next to storeframe. make-screenshot-documents.py stays as the entry point and keeps what is this app's: where the documents go, and the locale table from store_screenshots.py. It refuses to run against a different sampledoc version than the pinned one, so the pictures do not change with whoever takes them. The output is the same, byte for byte, as the old script wrote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZb2gUX4HQfKXWeZ3UQ
andiwand
force-pushed
the
use-sampledoc-package
branch
from
November 14, 2026 14:26
de730ad to
fa3e817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
The documents the store screenshots open were written by
scripts/make-screenshot-documents.py. That was 2,200 lines of generator and translations, and OpenDocument.ios carried an older copy of it. The generator now lives in its own repo, opendocument-app/sampledoc, and is published on PyPI assampledoc. This PR switches the app to it.scripts/requirements.txtpinssampledoc==0.1.0next tostoreframe(from Frame store screenshots with storeframe #760). The release workflow's screenshot job installs from it.scripts/make-screenshot-documents.pyis now a ~90-line wrapper with the same name, arguments and output location. The Fastfile,ScreenshotTestsand the docs that point to it are unchanged. It keeps the locale table fromstore_screenshots.LOCALES, which goes intoscreenshot-names.jsonas before. It exits if the installedsampledocisn't the pinned version, so the pictures don't depend on who takes them.scripts/requirements.txt, and that the wording of the documents now lives in sampledoc.Output is unchanged. I ran the old script and the new wrapper and compared the results with
diff -r. All 135 documents andscreenshot-names.jsonare byte-for-byte identical.Tested locally in a clean venv installed from
scripts/requirements.txt: the full run,--language en, sampledoc not installed, and a version mismatch. I haven't run a screenshot lane; the release workflow's screenshot job is the first real run.The iOS change is opendocument-app/OpenDocument.ios#231.