Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,12 @@ jobs:
with:
python-version: "3.13"

# Pillow draws the frames. The fonts are for the three locales Nunito cannot
# set - hindi, japanese and chinese - which frame-screenshots.py refuses to
# storeframe draws the frames. The fonts are for the three locales Nunito cannot
# set - hindi, japanese and chinese - which storeframe refuses to
# draw as tofu, so a runner without them fails rather than shipping squares.
- name: python and fonts
run: |
python3 -m pip install --quiet Pillow
python3 -m pip install --quiet -r scripts/requirements.txt
sudo apt-get update -qq
sudo apt-get install -y -qq fonts-noto-core fonts-noto-cjk

Expand Down
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,19 +172,21 @@ The release run takes the store screenshots from the build it ships. Nothing is
Six screens on a phone and a tablet in fifteen locales, plus a feature graphic per locale
drawn from the first screenshot. The tablet set fills both tablet slots.

To take them by hand you need one emulator on adb running **Android 15 or newer** and Pillow:
To take them by hand you need one emulator on adb running **Android 15 or newer** and
[storeframe](https://github.com/andiwand/storeframe):

```sh
python3 -m pip install Pillow
python3 -m pip install -r scripts/requirements.txt
bundle exec fastlane android screenshots # every locale, phone
ODR_SCREENSHOT_DEVICE=tablet bundle exec fastlane android screenshots
ODR_SCREENSHOT_LANGUAGES=en-US,de-DE bundle exec fastlane android screenshots
```

`ANDROID_SERIAL` picks the device when several are attached. Raw captures land in
`fastlane/screenshots/`, the framed set and feature graphics in `fastlane/framed/`. Running
`scripts/frame-screenshots.py` alone re-frames the captures, so a changed headline in
`fastlane/frames/frames.json` costs seconds. Below API 35 the status bar has a white clock on
`python3 -m storeframe frame fastlane/frames/frames.json --platform android --captured
fastlane/screenshots --out fastlane/framed --feature-graphic` alone re-frames the captures,
so a changed headline in `fastlane/frames/frames.json` costs seconds. Below API 35 the status bar has a white clock on
a white bar, so `ScreenshotTests` refuses to run there.

`hi-IN`, `ja-JP` and `zh-CN` are set in a system font. On Debian install `fonts-noto-core`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ import org.junit.runner.RunWith
* The pictures the play store shows.
*
* Six screens, in every locale the listing is written in, on whichever device the runner is
* driving. The edit is taken twice, the second time as lite shows it - see [editing].
* `scripts/frame-screenshots.py` then frames what this writes and `scripts/store_screenshots.py`
* driving. The edit is taken twice, the second time as lite shows it - see [editing]. storeframe
* (`scripts/requirements.txt`) then frames what this writes and `scripts/store_screenshots.py`
* checks the set and stages it for supply - the names below are the names those expect, and their
* order is the order the store shows them in.
*
Expand Down
12 changes: 7 additions & 5 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ SCREENSHOT_DIR = File.join(ROOT, "fastlane", "screenshots").freeze
FRAMED_DIR = File.join(ROOT, "fastlane", "framed").freeze

MAKE_DOCUMENTS = File.join(ROOT, "scripts", "make-screenshot-documents.py").freeze
FRAME_SCREENSHOTS = File.join(ROOT, "scripts", "frame-screenshots.py").freeze
# The design storeframe frames the captures with (scripts/requirements.txt).
FRAMES_DESIGN = File.join(ROOT, "fastlane", "frames", "frames.json").freeze
STORE_SCREENSHOTS = File.join(ROOT, "scripts", "store_screenshots.py").freeze

# The devices the store keeps a set for. The name is written into every file the
Expand Down Expand Up @@ -370,10 +371,11 @@ platform :android do
UI.message("took #{taken.length} screenshots")

# A raw capture is not what the store shows. The framing is separate from the
# photography so that changing a headline costs a second of Pillow rather than
# a quarter hour of emulators - rerun this script alone after an edit to
# fastlane/frames/frames.json.
sh("python3", FRAME_SCREENSHOTS)
# photography so that changing a headline costs seconds of storeframe rather
# than a quarter hour of emulators - rerun this step alone (see README.md)
# after an edit to fastlane/frames/frames.json.
sh("python3", "-m", "storeframe", "frame", FRAMES_DESIGN, "--platform", "android",
"--captured", SCREENSHOT_DIR, "--out", FRAMED_DIR, "--feature-graphic")

# what came out is what the store would be given, so it is checked here rather
# than at upload time on the other side of the run
Expand Down
Binary file removed fastlane/frames/Nunito[wght].ttf
Binary file not shown.
93 changes: 0 additions & 93 deletions fastlane/frames/OFL.txt

This file was deleted.

7 changes: 4 additions & 3 deletions fastlane/frames/frames.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"_comment": [
"What the play store pictures show, and what they say in every language.",
"scripts/frame-screenshots.py draws them; see that file for the geometry.",
"storeframe (scripts/requirements.txt) draws them, in its tabs style; see",
"https://github.com/andiwand/storeframe for the geometry.",
"",
"One entry per screen, in the order the store shows them, named as the",
"screenshot test writes them. `headline` is two lines: the first is set",
Expand All @@ -10,9 +11,8 @@
"",
"Fifteen locales, the ones scripts/store-listing.py names. Nunito sets",
"eleven of them; hi-IN, ja-JP and zh-CN are set in a system font, which is",
"the one thing frame-screenshots.py needs that is not in this directory."
"the one thing storeframe needs that does not come with it."
],
"font": "Nunito[wght].ttf",
"backgrounds": {
"orange": [
"#f4b663",
Expand Down Expand Up @@ -248,6 +248,7 @@
},
{
"name": "04-edit",
"aliases": ["04-edit-lite"],
"background": "blue",
"chips": [
"odt"
Expand Down
Loading
Loading