Repository navigation
gps_guard: remove time alert telemetry - #3813
Merged
Merged
Conversation
|
@fdlamotte thanks for the cleanup, agreed: an analog telemetry channel is not a clear way to report an alert, the CLI There were two small leftovers, a docs sentence about the telemetry channel and the now unused |
fdlamotte
pushed a commit
that referenced
this pull request
Nov 11, 2026
#3813 removed the telemetry channel for the GPS time alert. Remove the docs sentence that still described it and the now unused GpsGuard::getAlertOffset().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using telemetry channels for alerts might not be understood by casual user
Also it's using an Analog telemetry type, which can be confusing ... maybe adding a String type would be better (but I don't think using telemetry for alerts in main firmware is good, better off in a custom firmware, where experimental tweaks are better ...)
@AlexandrTyshchenko don't think I broke anything by removing this alert, if so please ping me ;)