Repository navigation
Conversation
meshcore-dev#3813 removed the telemetry channel for the GPS time alert. Remove the docs sentence that still described it and the now unused GpsGuard::getAlertOffset().
Collaborator
|
Thank you for watching this ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3813, which removed the GPS time alert from telemetry:
docs/cli_commands.md: remove the sentence saying the alert offset is reported in telemetry.GpsGuard.h: removegetAlertOffset(), no longer used anywhere.The alert itself stays in the CLI (
gps guardshowsALERT gps-clk ...,gps guard accept). Agree with the reasoning in #3813.Built: ProMicro_sensor with
-D GPS_GUARD.