Repository navigation
HCK-18362: fix boolean false in separate column DEFAULT statements - #208
Merged
taras-dubyk merged 1 commit intoOct 30, 2026
Merged
Conversation
assignTemplates treated false as missing when substituting template placeholders, which produced empty ALTER COLUMN SET DEFAULT clauses. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Sylvie-P
changed the title
Sylvie-P
changed the title
This was referenced Oct 29, 2026
Merged
taras-dubyk
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assignTemplatesso booleanfalseis not treated as a missing placeholder when generatingALTER COLUMN ... SET DEFAULTscripts.Root cause
Separate FE statements use the
updateColumnDefaultValuetemplate; substitution went throughassignTemplates, which used a truthy check and droppedfalse(whiletrue, numbers, and inline CREATE were unaffected).Test plan
defaultValue: false→SET DEFAULT false;falseand "Column Default Values – In separate statements"ALTER TABLE ... SET DEFAULT false;true, numeric defaults, and inline modeCross-plugin
Same
assignTemplatesfalsy check exists in other plugins (YugabyteDB, CockroachDB, Db2, Oracle, etc.); follow-up only where boolean defaults reach that template path.