Repository navigation
Conversation
assignTemplates treated false as missing when filling placeholders, which broke SET DEFAULT false in separate FE statements. Co-authored-by: Cursor <cursoragent@cursor.com>
getColumnDefault skipped false because of a truthy check; separate ALTER was already fixed via assignTemplates. Co-authored-by: Cursor <cursoragent@cursor.com>
Document boolean in DefaultValue and use an explicit defined-value check instead of === true/false. Co-authored-by: Cursor <cursoragent@cursor.com>
Use explicit boolean and zero checks instead of hasDefault chain. Co-authored-by: Cursor <cursoragent@cursor.com>
taras-dubyk
reviewed
Oct 30, 2026
…tColumnDefault.js Co-authored-by: Taras Dubyk <tarass.dubyk@gmail.com>
Keep reviewer intent (treat only null/undefined as missing) via != null. Co-authored-by: Cursor <cursoragent@cursor.com>
|
taras-dubyk
approved these changes
Oct 30, 2026
taras-dubyk
enabled auto-merge (squash)
October 30, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Summary - Fix `assignTemplates` so boolean `false` is not treated as a missing placeholder when generating separate column DEFAULT statements. - [HCK-18367](https://hackolade.atlassian.net/browse/HCK-18367) (parent [HCK-18361](https://hackolade.atlassian.net/browse/HCK-18361)). - Same change as [hackolade/PostgreSQL#208](https://github.com/hackolade/PostgreSQL/pull/208).
Test plan
false, separate statements →SET DEFAULT falseMade with Cursor