[jcogilvie]

Description of your changes

Summary

A pure code move with no behaviour change. crossplane resource simulate keeps the same output, flags, help and exit codes.

Why

project simulate (#436) needs the same diff server lifecycle, per-resource planning and kubeconfig handling. If the code moves into shared packages first, #436's diff for these files shows only its new behaviour, not about 1.2k lines of moved code.

What changed

• internal/simulate/simulate.go: Router, Planner / NewPlanner / Plan (this was Cmd.simulateOne; the object store and CRD defaults caches now live inside the Planner), fetchLive, the object store cache, providerConfigMapping, RelevantProviderImages.
• internal/simulate/servers.go: the runtime annotation constants, EnsureServers / StopServers (the start-behind-spinner, skipped-report and cleanup code from Run), ImageConfigs, NeedsDocker, LoadProviderInputs, LoadImageConfigs.
• internal/simulate/defaults.go: moved with git mv, unchanged.
• internal/kube/config.go: RESTConfig, the kubeconfig, impersonation and QPS/Burst setup from setupKubeClient, with a new unit test.
• cmd/crossplane/simulate/simulate.go keeps only the command: flags, help, AfterApply, Run and the client and REST mapper setup.
• Tests moved to internal/simulate/{simulate,servers}_test.go. The assertions are unchanged; they now call the exported names, and TestSimulateOne is now TestPlanner.

Testing

• ./nix.sh run .#test and ./nix.sh run .#lint pass.
• resource simulate --help and the error output for a missing -f file are byte-identical to main's.

Related

• feat(project): add alpha project simulate on the ported crossplane-diff engine #436: split out of it at adamwg's request, so that its diff shows only new code.
• Sibling split-outs from feat(project): add alpha project simulate on the ported crossplane-diff engine #436: fix(render): stale-backend errors, CROSSPLANE_DOCKER_NETWORK for every engine #477, refactor(project): share one xpkg client constructor; clamp build concurrency to 1 #478, feat(simulate)!: exit 3 on changes and 1 on errored plans in resource simulate #480. feat(simulate)!: exit 3 on changes and 1 on errored plans in resource simulate #480 also edits the end of resource simulate's Run, so whichever merges second has a small conflict.

I have:

• Read and followed Crossplane's contribution process.
• Run ./nix.sh flake check to ensure this PR is ready for review. (./nix.sh run .#test and ./nix.sh run .#lint pass.)
• Added or updated unit tests.
• Linked a PR or a docs tracking issue to document this change. (pure move, no user-facing change)
• Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: crossplane/cli
• Branch: main
• File: .coderabbit.yaml
• Commit: bf5a02b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: c973a2b2-200a-426b-849f-dc0c37b376c1

Commits

Reviewing files that changed from the base of the PR and between bf5a02b and dd62c0c.

Files selected for processing: 8

• cmd/crossplane/simulate/simulate.go
• internal/kube/config.go
• internal/kube/config_test.go
• internal/simulate/defaults.go
• internal/simulate/servers.go
• internal/simulate/servers_test.go
• internal/simulate/simulate.go
• internal/simulate/simulate_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[adamwg]

Thanks, lgtm.