Skip to content

chore: retire v0.7 from maintenance defaults - #3654

Merged
dheerajodha merged 1 commit into
conforma:mainfrom
dheerajodha:EC-2344
Oct 29, 2026
Merged

dheerajodha merged 1 commit into
conforma:mainfrom
dheerajodha:EC-2344

Conversation

@dheerajodha

@dheerajodha dheerajodha commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What:

Update the dependency-upgrade and UBI-bump helpers to default to release-v0.8, release-v0.9, and main.

Why:

Conforma CLI v0.7 is being retired now that v0.9 is available. Routine maintenance should cover the newest two release branches and main. Explicit branch arguments continue to override these defaults.

Related retirement PRs: #3655 and conforma/.github#107.

Validation:

  • Bash syntax checks passed for both scripts.
  • Verified both argument parsers select v0.8, v0.9, and main by default.
  • git diff --check passed.

Tickets:

Ref: https://redhat.atlassian.net/browse/EC-2344

Keep the supported release branches, v0.8 and v0.9, plus main in the dependency and UBI upgrade helpers.

Ref: https://redhat.atlassian.net/browse/EC-2344
@dheerajodha
dheerajodha requested a review from a team as a code owner October 29, 2026 11:55
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 2c0eff96-5b08-4682-9a1a-b0e2127611e9
Commits

Reviewing files that changed from the base of the PR and between c376db9 and 285d55c.

Files selected for processing: 2
  • hack/go-mod-upgrade-prs.sh
  • hack/ubi-bump-prs.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The Go module upgrade and UBI bump scripts now use release-v0.8, release-v0.9, and main when no branches are supplied. Explicit branch arguments are unchanged.

Changes: Default branch selection

Layer / File(s) Summary
Update default branch lists
hack/go-mod-upgrade-prs.sh, hack/ubi-bump-prs.sh
Both scripts replace release-v0.7 with release-v0.9 in their default branch lists.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: simonbaird, acepresso

Merge Risk: Minimal · up to 285d5

The scripts now select the intended maintenance branches without a known merge-blocking issue.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes retiring v0.7 from the maintenance defaults, which matches the changes to both helper scripts.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the required template. It has What, Why, and Tickets sections, and it adds a Validation section. The What section states the change: both helpers now default to release-v0.8, r…
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Full details: Description check

Explanation

The description follows the required template. It has What, Why, and Tickets sections, and it adds a Validation section. The What section states the change: both helpers now default to release-v0.8, release-v0.9, and main. The Why section gives the context: Conforma CLI v0.7 is retired, explicit branch arguments still override defaults, and related retirement PRs are linked. The Tickets section links EC-2344.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 29, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

XS configuration-only change (2 files, 4 lines) retiring v0.7 defaults from two maintenance shell scripts; low churn, no security or protected-path exposure, and zero test coverage expected for these helpers, yielding a moderate composite of Tier 1 (1.63) × 62% plus Tier 2 (1.43) × 38% ≈ 1.55, rounded to 2.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR modifies maintenance helper scripts in hack/, matching the tooling label.

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W119 -->

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge tooling labels Oct 29, 2026
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.61% <ø> (ø)
generative 12.22% <ø> (ø)
integration 23.62% <ø> (ø)
unit 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BohdanMar BohdanMar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheerajodha
dheerajodha merged commit e669d75 into conforma:main Oct 29, 2026
88 checks passed
@dheerajodha
dheerajodha deleted the EC-2344 branch October 29, 2026 13:31
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3654 — chore: retire v0.7 from maintenance script defaults

This was a clean, straightforward workflow with no significant issues.

Timeline

  1. 11:55:46Z — PR #3654 created by dheerajodha (2 files, 2 lines changed)
  2. 11:56:05Z — Review agent dispatched (run 40869175102)
  3. 12:05:28–32Z — Review agent posted risk assessment (moderate, 2/5), "Looks good to me", and approved
  4. 12:59:34Z — cuipinghuo approved (no comments)
  5. 13:28:21Z — BohdanMar approved ("LGTM")
  6. 13:31:47Z — PR merged by dheerajodha

Workflow quality

  • Review quality: Appropriate for this trivial change. No false positives, no missed issues.
  • Rework rate: Zero. Single commit, merged without changes.
  • Token cost: Review ran once (~10 min), no redundant work.
  • Time to resolution: ~1.5 hours, mostly waiting for human approvals.
  • Autonomy readiness: Human reviewers added no analytical content beyond the agent's review; both simply approved.

Judge scores

Score Candidate Disposition
1/5 Risk assessment slightly high (2/5) for trivial 2-line config change summary-only — minor quibble on single PR; already covered by fullsend-ai/fullsend #7889, #8096, #8383, #4698, #8424
1/5 ~10 min review for 2-line change summary-only — reasonable turnaround, not causing meaningful delay
2/5 Human reviews added no analytical content beyond agent summary-only — speculative autonomy observation; partially covered by fullsend-ai/fullsend #8383

No candidates scored 4 or above. No proposals filed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate size: XS tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants