Skip to content

chore: Add release-v0.9 to ubi-bump-prs.sh default branches - #3636

Closed
cuipinghuo wants to merge 1 commit into
conforma:mainfrom
cuipinghuo:fix-ubi-bump-default-branches
Closed

cuipinghuo wants to merge 1 commit into
conforma:mainfrom
cuipinghuo:fix-ubi-bump-default-branches

Conversation

@cuipinghuo

Copy link
Copy Markdown
Contributor

What:

Add release-v0.9 to the default branch list in hack/ubi-bump-prs.sh.

-  BRANCHES=(release-v0.7 release-v0.8 main)
+  BRANCHES=(release-v0.7 release-v0.8 release-v0.9 main)

Why:

Running hack/ubi-bump-prs.sh without arguments only produced UBI bump PRs for release-v0.7, release-v0.8, and main, silently skipping release-v0.9 — an active, maintained release branch (within Renovate's baseBranchPatterns release-v0.7+). This caused the v0.9 bump to be missed on a manual run (see EC-2343, where the v0.9 PR had to be created separately). Adding it keeps the default run aligned with the maintained release window.

Tickets:

Ref: https://redhat.atlassian.net/browse/EC-2343

🤖 Generated with Claude Code

@cuipinghuo
cuipinghuo requested a review from a team as a code owner October 23, 2026 19:17
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d7c2176b-c584-4605-bc14-177b0a33b5d8
📥 Commits

Reviewing files that changed from the base of the PR and between 5d22a0b and 11a4960.

📒 Files selected for processing: 1
  • hack/ubi-bump-prs.sh

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Oct 23, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Single-line addition to a utility shell script in hack/ with no protected paths, security-sensitive files, CI workflow changes, or dependency changes; zero churn in 30 days and single authorship; Tier 1 signals identical to prior run, anchoring preserves prior score of 1.

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Single-line addition to a shell script in hack/ with no protected paths, security sensitivity, or dependency changes; low churn and single authorship; composite 1.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Looks good to me

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W119 -->

Previous run

Looks good to me

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W119 -->

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 23, 2026
The default branch list in hack/ubi-bump-prs.sh was missing release-v0.9,
so running the script without arguments only produced UBI bump PRs for
release-v0.7, release-v0.8, and main — silently skipping release-v0.9,
which is an active, maintained release branch (covered by Renovate's
baseBranchPatterns). Add it so the default run matches the maintained
release window.

Ref: https://redhat.atlassian.net/browse/EC-2343

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: cuipinghuo <chuo@redhat.com>
@cuipinghuo
cuipinghuo force-pushed the fix-ubi-bump-default-branches branch from 55e74dc to 11a4960 Compare October 23, 2026 20:16
@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review October 23, 2026 20:29

Superseded by updated review

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.61% <ø> (ø)
generative 12.22% <ø> (ø)
integration 23.62% <ø> (ø)
unit 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dheerajodha

Copy link
Copy Markdown
Contributor

Maybe it needs a rebase to get the bumps that fixes the vulnerability

@cuipinghuo

Copy link
Copy Markdown
Contributor Author

closing this since #3654 covered this.

@cuipinghuo cuipinghuo closed this Oct 29, 2026
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3636 — chore: Add release-v0.9 to ubi-bump-prs.sh default branches

Outcome: Closed without merge (superseded by PR #3654).

Timeline

  1. Oct 23 19:17 — cuipinghuo opened PR with a 1-line change to hack/ubi-bump-prs.sh, adding release-v0.9 to the default branches list.
  2. Oct 23 19:18–19:31 — Review agent ran (~13 min). Posted risk assessment (low, 1/5) and review ("Looks good to me", no findings). Applied risk/low and ready-for-merge labels.
  3. Oct 23 19:35 — simonbaird (MEMBER) approved.
  4. Oct 23 ~20:16 — Author force-pushed (same diff, different SHA). Triggered a second review run.
  5. Oct 23 20:17–20:30 — Second review agent run (~13 min). Same result: "Looks good to me". First bot review dismissed, replaced with approval.
  6. Oct 28 17:31 — dheerajodha (CONTRIBUTOR) approved.
  7. Oct 29 12:02 — dheerajodha suggested a rebase for vulnerability fixes.
  8. Oct 29 13:02 — cuipinghuo closed PR, noting PR chore: retire v0.7 from maintenance defaults #3654 (a broader fix retiring v0.7 and adding v0.9 across two scripts) superseded it.

Assessment

The agent workflow performed well on this trivial PR. The review agent correctly identified the 1-line change as low-risk and approved with no findings — the right call. Risk scoring was accurate. No rework cycles were needed.

Three candidate improvements were evaluated, all scoring below the filing threshold (0–2/5) and covered by existing issues:

Judge scores

Score Candidate Disposition
2/5 Redundant review on unchanged diff after force-push summary-only (duplicates: fullsend-ai/fullsend #8099, #8127, #6968, #7237, #7628)
2/5 ~13 min review for XS/1-line config change summary-only (duplicates: fullsend-ai/fullsend #6891, #1900)
1/5 PR superseded by broader human fix summary-only (human coordination, not agent-actionable)

Redundant review after force-push: The author force-pushed the same 1-line diff (only the commit SHA changed), triggering a second ~13 min review that produced the identical "Looks good to me" result. This is evidence for the cluster of existing fullsend-ai/fullsend issues proposing semantic-diff gating for re-review dispatch (#8099, #8127, #6968, #7237, #7628).

Review effort for trivial changes: The review agent spent ~13 min on a 1-line config change. Existing issues fullsend-ai/fullsend #6891 and #1900 propose lighter review paths for trivially-scoped PRs.

Superseded PR: PR #3636 sat unmerged for 6 days despite ready-for-merge label and all approvals. PR #3654 then arrived with a broader scope (retiring v0.7 and adding v0.9 across two scripts). This is human workflow coordination, not an agent gap.

No proposals filed — all candidates are well-covered by existing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants