Skip to content

chore: retire v0.7 build pipelines - #3655

Merged
dheerajodha merged 1 commit into
conforma:release-v0.7from
dheerajodha:codex/EC-2344-purge-v0.7
Oct 30, 2026
Merged

dheerajodha merged 1 commit into
conforma:release-v0.7from
dheerajodha:codex/EC-2344-purge-v0.7

Conversation

@dheerajodha

@dheerajodha dheerajodha commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What:

Remove .tekton/cli-v07-pull-request.yaml and .tekton/cli-v07-push.yaml from release-v0.7.

Why:

Conforma CLI v0.7 is being retired now that v0.9 is available. Removing its Pipelines as Code definitions stops Konflux builds for pull-request and push events on the retired branch. This follows the v0.6 retirement in #3313.

Related retirement PRs: #3654 and conforma/.github#107. Merge this pipeline removal before retiring the v0.7 Konflux tenant resources.

Validation:

  • Confirmed both removed PipelineRuns target release-v0.7 and component cli-v07.
  • Confirmed the diff only deletes the two v0.7 pipeline files.
  • git diff --check passed.

Tickets:

Ref: https://redhat.atlassian.net/browse/EC-2344

Retire the release-v0.7 build pipelines so Konflux no longer triggers pull-request or push builds for cli-v07.

Ref: https://redhat.atlassian.net/browse/EC-2344
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 3a8322b2-a8eb-4e18-9b6e-0b671ce71f53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:58 AM UTC · Completed 12:11 PM UTC

Commit: 7dc8db5 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.83

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 29, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Pure deletion of two retired v0.7 Tekton pipeline files following established v0.6 precedent (#3313); score elevated to moderate solely by aggregate line count (1099 deletions) and large blast radius, both of which carry lower actual risk given the deletion-only, branch-retirement nature of the change.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [stale-reference] hack/ubi-bump-prs.sh:57 — The default BRANCHES list still includes release-v0.7 even though this PR retires the v0.7 build pipelines. When this script runs without explicit branch arguments, it will attempt to process the retired branch. While the script handles missing branches gracefully (the git show at line 110 fails and triggers continue), the stale reference causes unnecessary processing and confusing output. The precedent set by the v0.6 retirement (Remove Pipelines as Code configuration for cli-v06 #3313) confirms these scripts should be updated: release-v0.6 was already removed from this file's default list.
    Remediation: Remove release-v0.7 from the default BRANCHES array on line 57.

  • [stale-reference] hack/go-mod-upgrade-prs.sh:73 — The default BRANCHES list still includes release-v0.7 even though this PR retires the v0.7 build pipelines. When run without explicit branch arguments, the script will attempt git ls-tree against the retired branch (line 128). Although the process substitution failure is handled gracefully (empty result leads to 'not found, skipping'), it produces misleading output and is inconsistent with retiring v0.7. The v0.6 branch was already cleaned from this file's defaults.
    Remediation: Remove release-v0.7 from the default BRANCHES array on line 73.


Labels: PR modifies CI/CD pipeline configuration files under .tekton/


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
generative 69.55% <ø> (ø)
integration 69.55% <ø> (ø)
unit 69.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robnester-rh robnester-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheerajodha
dheerajodha merged commit 56ed0b5 into conforma:release-v0.7 Oct 30, 2026
42 of 43 checks passed
@dheerajodha
dheerajodha deleted the codex/EC-2344-purge-v0.7 branch October 30, 2026 05:36
@fullsend-ai-retro

fullsend-ai-retro Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 5:38 AM UTC · Completed 5:48 AM UTC

Commit: 7dc8db5 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.74

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3655 — chore: retire v0.7 build pipelines

Timeline: PR opened 2026-10-29 11:55 UTC by dheerajodha, targeting release-v0.7. Review agent ran 11:58–12:11 UTC (opus, high effort, $3.83). Two human approvals by 14:35 UTC. Merged 2026-10-30 05:36 UTC.

What happened: This deletion-only PR removed two .tekton/ pipeline YAML files (1099 deletions, 0 additions) from release-v0.7, following the v0.6 retirement precedent in #3313. The review agent flagged two medium "stale-reference" findings in hack/ubi-bump-prs.sh:57 and hack/go-mod-upgrade-prs.sh:73, requesting changes. Both findings were false positives — these hack scripts do not exist on release-v0.7 at all. They exist only on main. The review agent was working against a main checkout rather than the PR's base branch.

Root cause: The target-repo checkout defaulted to main instead of using the PR's base ref (release-v0.7). This caused the agent to search files from the wrong branch, finding stale references that are irrelevant to the PR's target branch.

Human reviewers handled it correctly. cuipinghuo approved and robnester-rh approved with "LGTM", both correctly recognizing the findings were inapplicable. The PR was merged without addressing the false positive findings.

Evidence for existing issues (no new proposals needed)

fullsend-ai/fullsend#5477 — "Target-repo checkout should use PR base ref for pull_request_target events." This retro adds a second recurrence: same root cause, same repo (conforma/cli), different release branch (release-v0.7 vs the original release-v0.8). Impact: 2 false positive findings, a spurious CHANGES_REQUESTED verdict, $3.83 in wasted review cost, and unnecessary human effort to evaluate and dismiss the findings.

fullsend-ai/fullsend#6891 — "Add pre-flight scope heuristic to adjust review effort/model for trivially-scoped PRs." This retro adds evidence: a 0-addition, 2-file deletion PR ran at high effort on opus ($3.83, ~13 min). A pre-flight heuristic recognizing pure-deletion or config-only PRs could have selected low effort on a lighter model, reducing cost to under $0.50 and runtime proportionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants