Repository navigation
mrpt_gui: no wxpython host dependency, rebuild - #227
Open
Tobias-Fischer wants to merge 1 commit into
Open
Tobias-Fischer wants to merge 1 commit into
Tobias-Fischer wants to merge 1 commit into
Conversation
mrpt_gui links the C++ wxWidgets libraries (libwx_*), but its wxwidgets/wx-common rosdep keys map to wxpython, which its recipes had as a host dependency (never a run one). conda-forge's wxpython builds for wxwidgets 3.3.4 need sip >=6.17, while pyqt6 needs sip <6.16 and the pins hold sip at 6.15, so with the pinning update (#165) check-deps, which solves host and run requirements together, reports conflicts with python_qt_binding / qt_gui_cpp in lyrical and rolling. mrpt_gui is rebuilt in all distributions (humble 24, jazzy 30, lyrical 34, rolling 35). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
mrpt-gui-no-wxpython
branch
from
November 14, 2026 12:07
42bd53e to
ffa09a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mrpt_gui links the C++ wxWidgets libraries (
libwx_*), but itswxwidgetsandwx-commonrosdep keys map towxpython, so its recipes had wxpython as a host dependency. It was never a run dependency: no published mrpt_gui package depends on wxpython (they depend onwxwidgetsthrough its run_exports).That unneeded host dependency causes the new check-deps conflicts on #165, which solves host and run requirements together:
sip >=6.17;sip <6.16, and our pins holdsipat 6.15;This PR drops wxpython from mrpt_gui's host requirements; wxwidgets stays a direct host dependency. mrpt_gui is rebuilt in all four distributions (humble 24, jazzy 30, lyrical 34, rolling 35); #165 bumps the same build numbers.
Checked: with this change on top of #165,
check-deps(linux-64) reports no new conflicts for lyrical and rolling; only the ones that were already there remain. mrpt_gui is the only package that depends on wxpython, in every distribution.🤖 Generated with Claude Code