Skip to content

Per-package files and dependency fixes next to the package's other settings - #224

Open
Tobias-Fischer wants to merge 1 commit into
vinca-rs/3-rosdep-mappingsfrom
vinca-rs/4-package-files
Open

Tobias-Fischer wants to merge 1 commit into
vinca-rs/3-rosdep-mappingsfrom
vinca-rs/4-package-files

Conversation

@Tobias-Fischer

@Tobias-Fischer Tobias-Fischer commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

A package's extra files and dependency fixes sit next to its other settings.

  • Dependency fixes live in pkg_additional_info.yaml: each layer's patch/dependencies.yaml is merged into it, so a package's add_*/remove_* keys sit next to its build_number and CMake args. Both files were keyed, layered and merged per package the same way; the merged files hold exactly what the two did (compared per package and key: the merge alone leaves the generated recipes unchanged; the vinca-rs bump below changes the Windows build scripts). import_distro merges an old repository's two files; the sort task, docs and skills follow.
  • ros_workspace's activation scripts live here (shared/files/ros2-ros-workspace/): vinca-rs copies a layer's files/<pkg>/ into that package's recipe.
  • rs check reports entries for packages the distribution (or, for shared/, no distribution) doesn't have: typos and leftovers. It found three in rolling, now removed (grid_map_octomap, gz_launch_vendor, slam_toolbox). A vinca-rs solve failure that isn't the solver's answer raises instead of counting as a conflict.
  • vinca-rs 0.1.9, which reads both (Per-package recipe files from the config; follow the split pixi PRs Tobias-Fischer/vinca-rs#7, One shared package selection for all distributions (vinca extends, ros2-* names, no kilted) #8) and builds ament_cmake with Ninja on Windows (run 43545144727: the long-named interface packages build on win-64).

Merging with #227: #227 edits shared/patch/dependencies.yaml, which this PR merges into pkg_additional_info.yaml. Whichever of the two lands second puts #227's remove_host: ["wxpython"] into the existing mrpt_gui entry of shared/pkg_additional_info.yaml, and its build numbers into the existing mrpt_gui entries of the distributions' pkg_additional_info.yaml (jazzy merges without a conflict but would end up with two mrpt_gui: keys).

A follow-up: #220 (one per-package folder for patches, tests and files).

🤖 Generated with Claude Code

…ttings

- Dependency fixes live in pkg_additional_info.yaml: each layer's
  patch/dependencies.yaml is merged into it, so a package's add_*/remove_* keys sit
  next to its build_number and cmake args. Both files were keyed, layered and
  merged per package the same way; the merged files hold exactly what the two did
  (compared per package and key). import_distro merges an old repository's two
  files; the sort task, docs and skills follow.
- ros_workspace's activation scripts live here (shared/files/ros2-ros-workspace/):
  vinca-rs copies a layer's files/<pkg>/ into that package's recipe.
- check reports entries for packages the distribution (or, for shared/, no
  distribution) doesn't have: typos and leftovers. It found three in rolling, now
  removed (grid_map_octomap, gz_launch_vendor, slam_toolbox). A vinca-rs solve
  failure that isn't the solver's answer raises instead of counting as a conflict.
- vinca-rs 0.1.9, which reads both (Tobias-Fischer/vinca-rs#7, #8) and builds
  ament_cmake with Ninja on Windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Tobias-Fischer
Tobias-Fischer force-pushed the vinca-rs/4-package-files branch from 7b61d9f to c436914 Compare November 14, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:none PR build: build no packages, only run the checks (tooling, CI or docs changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant