Repository navigation
BUG: Combine the EBSD fixes that need the next EbsdLib release - #1973
Open
imikejackson wants to merge 14 commits into
Open
imikejackson wants to merge 14 commits into
imikejackson wants to merge 14 commits into
Conversation
7 tasks done
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Nov 13, 2026
…Software#1967) Originally simplnx BlueQuartzSoftware#1967 (branch fix/ebsd-vv-filter-items), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…uartzSoftware#1962) Originally simplnx BlueQuartzSoftware#1962 (branch topic/gm3d_space_group_laue), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…ftware#1965) Originally simplnx BlueQuartzSoftware#1965 (branch topic/hex_to_square_ang_extension_case), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…lueQuartzSoftware#1968) Originally simplnx BlueQuartzSoftware#1968 (branch fix/read_h5ebsd_preflight_errors), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…ions (BlueQuartzSoftware#1969) Originally simplnx BlueQuartzSoftware#1969 (branch fix/orientation-axis-direction-validation), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…BCD GMT (BlueQuartzSoftware#1970) Originally simplnx BlueQuartzSoftware#1970 (branch fix/writegbcdgmt-crystal-structure-check), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…QuartzSoftware#1971) Originally simplnx BlueQuartzSoftware#1971 (branch fix/ebsd-reader-phase-table-checks), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…Software#1972) Originally simplnx BlueQuartzSoftware#1972 (branch fix/twin-boundaries-acos-clamp), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…lueQuartzSoftware#1961) Originally simplnx BlueQuartzSoftware#1961 (branch topic/rename_simplnx_h5support_mutex_macro), combined into this branch for the EbsdLib 3.1.4 update. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
- The merge of BlueQuartzSoftware#1962 into the combined branch joined the last BlueQuartzSoftware#1967 test case and the first BlueQuartzSoftware#1962 test case without the closing brace between them, so ReadGrainMapper3DTest.cpp did not compile. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…ter checks The combined EbsdLib rejects three malformed inputs in the reader, before the simplnx check that the test expected can run: - ReadAngData HeaderValidation steps: AngReader reports an XSTEP or YSTEP of "nan" or "1e999" as a header parse error (-115, EbsdLib "Report an error when an ANG header number cannot be parsed"). The filter check (-67602) still rejects -1 and 0. - ReadChannel5Data Empty phase list: CprReader reports a .cpr file without phases (-102300, EbsdLib "Report an error when a .cpr file defines no phases") before the filter check (-66502). - ReadH5Ebsd Phase table validation: EbsdLib rejects a LatticeConstants dataset without 6 values, so the volume reader returns no phases (-50027) before the lattice-constant check (-50028). Each input is still rejected with an error that names the file and the value. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* When EbsdLib returns no phases, error -50027 now gives the reader's error code and message, for example the EbsdLib -90350 message for a LatticeConstants dataset that does not hold 6 values. Before, the message said only that the phase information could not be read. * The phase-table test checks that the message contains -90350. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/next_ebsdlib_fixes
branch
from
November 14, 2026 19:34
841677f to
20b4e06
Compare
Fill the grayscale pipeline fixture by index instead of growing it with vector::insert, which triggers a gcc 13 -Wstringop-overflow false positive. The pixel bytes are unchanged. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch combines the simplnx pull requests that are tied to the next EbsdLib release into one branch, so that simplnx and EbsdLib each have one branch to build and test together. It builds and passes its tests against BlueQuartzSoftware/EbsdLib#86 (branch
topic/next_release_fixes).Each original pull request is merged with
--no-ff, so its commits and history are kept. The original pull requests are closed with a link to this one.Merged pull requests
Closes #1953
Closes #1882
Closes #1906
Closes #1946
Closes #1957
Conflict resolutions and decisions
ValidateSpaceGroupsfrom BUG: Use one EbsdLib space-group mapping in Read GrainMapper3D #1962 (-67600, the code both pull requests use) and thenGetLaueOpsFromSpaceGroupNumber, so there is one space-group check and no call to the removedGetOrientationOpsFromSpaceGroupNumber. For the header vector sizes, the codes of BUG: Use one EbsdLib space-group mapping in Read GrainMapper3D #1962 (-38610 to -38613) are kept; BUG: Validate EBSD reader headers, scans and slice ranges #1967's -67622 check stays insideValidateOriginHeaderbut file data no longer reaches it. BUG: Validate EBSD reader headers, scans and slice ranges #1967's testHeader vector sizeexpects the BUG: Use one EbsdLib space-group mapping in Read GrainMapper3D #1962 codes.ValidateOemScanCompatibilityfrom BUG: Validate EBSD reader headers, scans and slice ranges #1967 (-67606), with the message wording of BUG: Fix input validation in four EBSD and mesh filters #1965. BUG: Fix input validation in four EBSD and mesh filters #1965's -9592 and -9684 are removed. The execute-side -8972 check now runs only for readers other than OIM and Esprit (in practice H5OINA). Three assertions in BUG: Fix input validation in four EBSD and mesh filters #1965's tests expect -67606.IsAngFile(BUG: Fix input validation in four EBSD and mesh filters #1965) is built onNormalizedExtension(BUG: Validate EBSD reader headers, scans and slice ranges #1967); BUG: Fix input validation in four EBSD and mesh filters #1965's -44602 message and -44603 fix and BUG: Validate EBSD reader headers, scans and slice ranges #1967's -44604 output-path check are kept.}between test cases; they are fixed. Every changed test file has develop's test cases plus each pull request's additions, with no duplicate names.Changes needed for the combined EbsdLib
ReadAngData: HeaderValidation steps: an XSTEP or YSTEP ofnanor1e999gives -115 fromAngReader(EbsdLib#82), not -67602.ReadChannel5Data: Empty phase list: -102300 fromCprReader(EbsdLib#75), not -66502.ReadH5Ebsd: Phase table validation, short lattice constants: -50027 (EbsdLib#84), not -50028.Test Plan
ci-linux-x64preset withSIMPLNX_USE_LOCAL_EBSD_LIB=ON, EbsdLibtopic/next_release_fixes, H5Support v1.0.14): full ctest passes serially, 3972/3972. After the last two commits (the -50027 message and the EbsdLibH5CtfVolumeReaderfix), the OrientationAnalysis tests pass again, 520/520.x64-windows-v143, local EbsdLib#86 and H5Support v1.0.14): all 1478 targets build. The only warnings are 6 existing C4244 warnings in test files that this branch does not change. EbsdLib tests pass 516/516 and^OrientationAnalysis::tests pass 496/496, the same count as Linux for that pattern. The full simplnx suite was not run on Windows.simplnx-registryupdate).The
bluequartz-skillsplugin skills that AGENTS.md lists were not available in this environment; the changes followdocs/Coding_Knowledge_Base.md.🤖 Generated with Claude Code