Repository navigation
Description
Summary
The filter sweep found a set of defects that do not share a pattern with any other defect. Each one is a local mistake in one filter or in one shared helper. This issue tracks them in one place so that they are not lost. As of develop c26bd47 (2026-11-03), there were 72 findings in 50 filters and 5 other areas: 5 CRASH, 35 WRONG_DATA and 32 MINOR. On 2026-11-04 the list was reorganized: 15 MINOR items moved to #1917, and 7 items (L73 to L79) were added from #1899 and from the review of PR #1915. MINOR defects are tracked in #1917; documentation and comment defects in #1899. On 2026-11-05, item L82 (WRONG_DATA) was added from the review of PR #1923. Items L83 to L98 were added later.
2026-11-13: PRs #1961, #1962, #1965, #1967, #1968, #1969, #1970, #1971 and #1972 were closed and combined into #1973, which is built and tested with the combined EbsdLib branch BlueQuartzSoftware/EbsdLib#86 (it holds EbsdLib #70 to #85, which were closed into it). Items that named one of these pull requests now also name #1973. L89 and L90 are fixed by #1965, which is part of #1973. No item is ticked until #1973 is merged.
Status on 2026-11-12: there are 98 item numbers: 60 open, 20 fixed and 18 struck through.
-
Open (60): 8 CRASH, 32 WRONG_DATA, 3 ERROR and 17 MINOR. 35 of them have an open pull request (BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915: 23, BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921: 6, BUG: Combine the EBSD fixes that need the next EbsdLib release #1973: 5, ENH: Clear stale Feature Attribute Matrix data in geometry-changing filters (replaces #1748) #1913: 1). 25 have no pull request yet: 4 CRASH, 13 WRONG_DATA, 2 ERROR and 6 MINOR.
-
Fixed (20): 2 CRASH and 18 WRONG_DATA, by the merged pull requests BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 (11 items) and BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 (9 items).
-
Struck through (18): 15 MINOR items moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917, L64 moved to BUG: C03: Element DataArray tuple count not checked in 21 filters #1863, L65 moved to BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters #1867, and L92 is not a defect (see BUG: DBSCAN algorithms use an Epsilon of 0, negative or NaN when called without the filter #1887). In L93 and L97 only the direct-call part is struck through; the rest of each item is still open.
-
CRASH: the defect can crash NXRunner or DREAM3D-NX (out-of-bounds access, uncaught exception, division by zero, abort or hang).
-
WRONG_DATA: the filter writes incorrect output and gives no error.
-
ERROR: a missing input check lets bad input through, and the filter then fails later with an unrelated error.
-
MINOR: everything else (bad error messages, latent defects, wrong preflight values, stray objects). New MINOR defects go to BUG: Fix MINOR defects found by the filter sweep and reviews #1917. The 17 MINOR items that are still open here stay here.
Every finding is a candidate. An automated code-reading sweep found it (develop 4a7b71e, 2026-10-08), a second code reading confirmed it on develop 419f9db, and every line was checked again on develop c26bd47. Nobody ran the trigger yet. Each checklist line gives the trigger in plain words.
Each finding has a unique item number (L01 to L98). Refer to a finding by this number in commits and pull requests, for example "Fixes #1908 item L07". The numbers do not change; a fixed item is ticked, not removed. A moved item keeps its line, struck through, with its new item number.
Findings marked "6.5.171 errata: KI-###" are also defects in DREAM.3D 6.5.171. They are listed with that ID on the Known Issues in DREAM.3D 6.5.171 page. When one is fixed, update the DREAM3D-NX status of that entry.
#1900 fixed 18 findings of the original sweep before this issue was filed, so they are not listed: ArrayCalculatorFilter#1, BinaryDilateImageFilter#1, ComputeFeaturePhasesBinaryFilter#1, ComputeTriangleGeomVolumesFilter#4, ComputeVectorColorsFilter#1, ConvertColorToGrayScaleFilter#1, CropVertexGeometryFilter#2, FeatureFaceCurvatureFilter#5, PointSampleTriangleGeometryFilter#1, ReadCSVFileFilter#1, ReadH5EbsdFilter#2, ReadVtkStructuredPointsFilter#1, ScalarSegmentFeaturesFilter#3, StandardDeviationProjectionImageFilter#1, TriangleDihedralAngleFilter#1, UncertainRegularGridSampleSurfaceMeshFilter#4, WriteLAMMPSFileFilter#1 and WriteVtkRectilinearGridFilter#2.
Mechanism
There is no common mechanism. Each finding has its own cause, for example integer division, an off-by-one loop start, a missing null check or a wrong copy direction. Some findings are in shared code (SegmentFeatures.cpp, ImageProcessingFilterUtilities.hpp, ImageRotationUtilities.cpp, MorphologyEngine.hpp, RenameDataAction.cpp, UpdateImageGeomAction.cpp). A fix there changes all filters that use that code.
An example (ComputeBoundingBoxStatsFilter, WRONG_DATA, item L10). For an even count, the median is the mean of the two middle values only when the cumulative frequency equals count / 2 + 1 exactly. For the values {1, 1, 2, 2}, the cumulative frequency jumps from 2 to 4, so the median is 2.0 and not 1.5:
ComputeBoundingBoxStatsDirect.cpp#L413-L427
const usize medianPosition = (stats.count / 2) + 1;
...
if(!state.medianFound && state.cumulativeFrequency >= medianPosition)
{
if(stats.count % 2 == 0 && state.cumulativeFrequency == medianPosition && state.previousValue.has_value())
{
stats.medianValue = (static_cast<float32>(state.previousValue.value()) + static_cast<float32>(entry.value)) / 2.0f;
}
else
{
stats.medianValue = static_cast<float32>(entry.value);
}Rule
- Each finding needs its own fix. There is no shared helper for this issue.
- Every fix starts with a unit test that fails on develop.
- Put checks in preflight when they do not need array values. Put value checks in execute.
- When a new preflight check makes an execute-time check unreachable, remove the execute-time check.
How to fix
- Pick one checklist line. Read the code at the permalink and the finding id.
- Write the failing test first (see "How to test").
- Make the smallest change that fixes the trigger. Each checklist line names the cause.
- If the fix is in shared code, run the tests of every filter that uses that code.
- A new filter error code must be more negative than -10000 and must be in the range that the filter already uses. Check that the code is unique with
git grep -nE -- "-NNNN([^0-9]|$)"(do not use\b). - If a finding has its own issue (marked "same defect"), fix it under that issue and tick it here.
- Name the item number in the commit message and in the pull request, and tick the item here when the pull request merges.
How to test
- Write the test before the fix. The test must fail on develop.
- Use the trigger from the checklist line as the test input. Make the input as small as possible (for example a 3x3x3 Image Geometry).
- CRASH: assert that preflight or execute returns an error and does not crash. For an out-of-bounds read, the test must fail under AddressSanitizer or produce a wrong value before the fix.
- WRONG_DATA: compare the output values with an independent expected result (oracle), for example a hand calculation or a closed-form value. Do not use the current output of the code as the expected result.
- For filters with Direct and Scanline algorithms, run the test in both through the existing algorithm-selection test scope (
UnitTest::SelectAlgorithmTestScenariosForInMemoryStores()orAlgorithmTestScope). - If you cannot reproduce a finding, do not force a fix. Write the reason in the PR and on this issue.
Conventions
- Use one PR for each group of related fixes (for example all RenameDataAction findings). Use one commit for each filter.
- Commit prefix
BUG:. Add aSigned-off-byline. Do not add AI attribution. - Every fix starts with a unit test that fails on develop.
- Value checks need an independent expected result (oracle), not the output of the code.
- Run ctest serially. Never use
-j, because the tests depend on each other. - Format with clang-format 19.1.1 and the repository
.clang-format. - Do not add per-filter documentation sentences about input requirements. The generated parameter table documents them.
- If a fix touches a filter that has a V&V report (
src/Plugins/<Plugin>/vv/<Filter>.md), update every file of that V&V package (report, deviations, provenance, test tables). V&V documents reference DREAM3D 6.5.171 only. - Rebase on develop. Never merge develop into the branch.
Checklist
The list is grouped by plugin, then by impact. Some findings in the SimplnxCore group are in core library code (src/simplnx/...) that the named filter uses.
SimplnxCore (52 findings: 21 open, 16 fixed, 15 moved to #1917)
CRASH (3: 1 open, 2 fixed)
- L01 · CRASH · CombineNodeBasedGeometriesFilter · CombineNodeBasedGeometries.cpp:59 — Preflight accepts geometries that all lack their element list (for example Shared Faces List). Execute then calls a method on a null pointer.
CombineNodeBasedGeometriesFilter#1— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L02 · CRASH · CreateAMScanPathsFilter · DataStructure.cpp:224 — DataStructure::makePath does not check the nullptr that DataGroup::Create returns under an Attribute Matrix. A path such as 'Image/Cell Data/Sub/X' crashes preflight (also Create Data Group and Create Attribute Matrix).
CreateAMScanPathsFilter#7— PR BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921 - L03 · CRASH · SplitDataArrayByTupleFilter · SplitDataArrayByTupleFilter.cpp:250 — There is no check that Split Dimension is less than the tuple-shape rank. When the shapes do not divide, the error message indexes both tuple shapes out of bounds in preflight.
SplitDataArrayByTupleFilter#1— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911
WRONG_DATA (26: 12 open, 14 fixed)
- L04 · WRONG_DATA · AlignSectionsFeatureCentroidFilter · AlignSectionsFeatureCentroid.cpp:130 — With Use Reference Slice on and a reference slice other than 0, the top Z section never gets a shift, because the loop starts at iter = 1. Legacy 6.5 does the same. (6.5.171 errata: KI-010)
AlignSectionsFeatureCentroidFilter#4— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L05 · WRONG_DATA · AppendImageGeometryFilter · DataArrayUtilities.hpp:1201 — With Direction = X and in-place append, ShiftDataX calls CopyData on overlapping ranges with a forward copy. Rows are overwritten before they are read.
AppendImageGeometryFilter#2— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L06 · WRONG_DATA · ApproximatePointCloudHullFilter · ApproximatePointCloudHull.cpp:89 — The grid is padded by half of 1/resolution, not by one voxel. A small resolution makes a very large grid; a large one leaves no empty border, so outer voxels drop out of the hull.
ApproximatePointCloudHullFilter#1— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L07 · WRONG_DATA · ArrayCalculatorFilter · ArrayCalculator.cpp:1812 — In
max("MC1", "MC2")[1], the index binds to the last argument, not to the function result. The values and the shape are wrong.ArrayCalculatorFilter#2— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L08 · WRONG_DATA · CombineStlFilesFilter · CombineStlFiles.cpp:150 — The File List is sorted by file name but Part Numbers by stem. For part.stl and part-2.stl, File List[k] does not name the file of Part Number k.
CombineStlFilesFilter#2— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L09 · WRONG_DATA · ComputeArrayHistogramByFeatureFilter · ComputeArrayHistogramByFeature.cpp:343 — When Min Value = Max Value, the modal bin range is written as (0, number of Features), which is not related to the data. Scanline has the same code.
ComputeArrayHistogramByFeatureFilter#8— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L10 · WRONG_DATA · ComputeBoundingBoxStatsFilter · ComputeBoundingBoxStatsDirect.cpp:421 — For an even count, the median uses the wrong pair: {1,1,2,2} gives 2.0, not 1.5. Direct and Scanline have the same logic.
ComputeBoundingBoxStatsFilter#2— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L11 · WRONG_DATA · ComputeFeatureClusteringFilter · ComputeFeatureClustering.cpp:74 — The RDF reference loop starts at i = 1 but divides by the full pair count. Every RDF bin is about 0.2% too high. (related: BUG: Feature clustering RDF reference is not normalized to unit mass #1820, same defect) (6.5.171 errata: KI-017)
ComputeFeatureClusteringFilter#5— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L12 · WRONG_DATA · ComputeVectorColorsFilter · ComputeVectorColors.cpp:101 — A vector with a very small negative Y component gets trend = 360.0f after the wrap. No color branch matches, so the cell is black. (6.5.171 errata: KI-014)
ComputeVectorColorsFilter#3— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L13 · WRONG_DATA · CreateAMScanPathsFilter · CreateAMScanPaths.cpp:209 — When a hatch line goes through a polygon vertex, both edges report a crossing. The pairing loop skips the duplicate pair and the hatch is lost. (related: BUG: Create AM Scan Paths creates hatches across exterior gaps #1795, partly)
CreateAMScanPathsFilter#5— PR BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921 - L14 · WRONG_DATA · CreatePythonSkeletonFilter · CreatePythonSkeleton.cpp:35 — The plugin human name is never used; the algorithm passes the plugin name twice. (related: BUG: Python plugin generator ignores the human-name parameter #1822, same defect)
CreatePythonSkeletonFilter#2— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L15 · WRONG_DATA · CreatePythonSkeletonFilter · CreatePythonSkeletonFilter.cpp:101 — Filter Names is split on ',' with no trim and no identifier check. 'A, B' makes a module named ' B' that Python cannot import.
CreatePythonSkeletonFilter#3— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L16 · WRONG_DATA · ExecuteProcessFilter · ExecuteProcess.cpp:145 — With Should Block on, stdout is written to the Output Log File two times.
ExecuteProcessFilter#4— PR BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921 - L17 · WRONG_DATA · FlyingEdges3DFilter · FlyingEdges.hpp:1231 — For integer input types, the edge weight uses integer division. Contour vertices snap to cube corners.
FlyingEdges3DFilter#1— PR BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921 - L18 · WRONG_DATA · HierarchicalSmoothFilter · HierarchicalSmooth.cpp:727 — For the second and later free-boundary loops,
j % thisSizeindexes the nodes of the first loop. The wrong node chains are smoothed. (related: BUG: Hierarchical smoothing moves fixed quadruple junctions #1793, partly)HierarchicalSmoothFilter#1— PR BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921 - L19 · WRONG_DATA · IdentifyDuplicateVerticesFilter · VertexUtilities.cpp:76 — Vertices are sorted on one axis and only adjacent entries are compared. Duplicates separated by a vertex with the same primary coordinate are missed. (related: BUG: Identify all duplicate vertices within coordinate ties #1783, same defect)
IdentifyDuplicateVerticesFilter#1— PR BUG: Fix 6 crash and wrong-data findings from the filter sweep (#1908) #1921 - L20 · WRONG_DATA · InterpolatePointCloudToRegularGridFilter · InterpolatePointCloudToRegularGrid.cpp:339 — Attribute Arrays to Copy writes a weighted mean, truncated to the type. For categorical data, Phases 1 and 3 give the value 2, which is not a real phase.
InterpolatePointCloudToRegularGridFilter#3— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L21 · WRONG_DATA · PadImageGeometryFilter · PadImageGeometry.cpp:109 — If any enabled axis has padding {0,0}, the algorithm returns before it copies Cell Data. The padded DataArrays stay all zeros; in place, the original data is lost.
PadImageGeometryFilter#1— PR ENH: Clear stale Feature Attribute Matrix data in geometry-changing filters (replaces #1748) #1913 - L22 · WRONG_DATA · PartitionGeometryFilter · PartitionGeometryFilter.cpp:497 — The Partition feature Attribute Matrix gets the input cell tuple shape, not the partition count plus Starting Feature ID.
PartitionGeometryFilter#9— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L23 · WRONG_DATA · QuickSurfaceMeshFilter · QuickSurfaceMeshDirect.cpp:1184 — When Face Labels are swapped (Feature Id of the cell < Feature Id of the neighbor), the transfer still uses the old order. Transferred side 0 does not match Face Labels[0]. Legacy does the same. (6.5.171 errata: KI-007)
QuickSurfaceMeshFilter#4— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L24 · WRONG_DATA · RegularGridSampleSurfaceMeshFilter · RegularGridSampleSurfaceMesh.cpp:268 — With 1-component labels, nested parts (part 2 inside part 1) toggle to the wrong Feature Id on exit (0 instead of 1).
RegularGridSampleSurfaceMeshFilter#3— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L25 · WRONG_DATA · RenameDataObjectFilter · RenameDataAction.cpp:86 — With Allow Overwrite on, RenameDataAction deletes the first object with the new name anywhere in the DataStructure, not the sibling in the same parent.
RenameDataObjectFilter#1— PR BUG: Fix 10 WRONG_DATA findings from the filter sweep (#1908) #1910 - L26 · WRONG_DATA · ScalarSegmentFeaturesFilter · SegmentFeatures.cpp:910 — Same shared SegmentFeatures code as EBSDSegmentFeaturesFilter: with Is Periodic on and all-neighbor connectivity, X/Y-wrapped diagonal neighbors in the next Z slice are not joined.
ScalarSegmentFeaturesFilter#1— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L27 · WRONG_DATA · SetImageGeomOriginScalingFilter · UpdateImageGeomAction.cpp:51 — With Put Input Origin at the Center of Geometry on and a negative origin, offset = |center| - |min| is wrong. The geometry is not centered on the origin.
SetImageGeomOriginScalingFilter#1— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L28 · WRONG_DATA · WriteOnScaleTableFileFilter · ImageRotationUtilities.cpp:83 — DetermineSpacing takes the spacing from the wrong axis for 3-cycle rotations, so output spacing and dims are wrong. The OnScale writer only detects this and fails with -12041. (6.5.171 errata: KI-008)
WriteOnScaleTableFileFilter#1— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L29 · WRONG_DATA · WriteVtkRectilinearGridFilter · WriteVtkRectilinearGrid.cpp:133 — In ASCII mode, coordinates are written with "%f ". Spacing 1e-7 makes all coordinates 0.000000. (6.5.171 errata: KI-016)
WriteVtkRectilinearGridFilter#3— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915
MINOR (23: 8 open, 15 moved to #1917)
- L30 · MINOR · AddBadDataFilter · AddBadData.cpp:303 — A StringArray or NeighborList in the Cell Data Attribute Matrix makes getDataRefAs throw. The filter fails with the generic error -2. (6.5.171 errata: KI-052)
AddBadDataFilter#4— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 -
L31 · MINOR · AddBadDataFilter · AddBadData.cpp:143 — std::mt19937 truncates the uint64 seed to 32 bits. Seeds 1 and 2^32+1 give the same output.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M01.AddBadDataFilter#5 -
L32 · MINOR · ArrayCalculatorFilter · ArrayCalculator.cpp:1677 — An index after a closing parenthesis, as inMoved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M04.("MC")[0] + "Scalar1", is not used in the shape check. A valid expression fails with -4024 or -4016.ArrayCalculatorFilter#8 -
L33 · MINOR · CombineTransformationMatricesFilter · CombineTransformationMatricesFilter.cpp:122 — The component-count check is inside the inner loop and never runs for the last array. Validation depends on the input order.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M05.CombineTransformationMatricesFilter#2 -
L34 · MINOR · ComputeArrayHistogramByFeatureFilter · ComputeArrayHistogramByFeatureFilter.cpp:185 — Output DataGroup Path accepts an Attribute Matrix, but a DataGroup cannot go into one. Preflight fails with the generic error -5301.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M06.ComputeArrayHistogramByFeatureFilter#9 -
L35 · MINOR · ComputeArrayHistogramFilter · ComputeArrayHistogramFilter.cpp:82 — Output DataGroup Path accepts an Attribute Matrix, but the filter always inserts a DataGroup. Preflight fails with a generic action error.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M07.ComputeArrayHistogramFilter#8 -
L36 · MINOR · ComputeBoundingBoxStatsFilter · ComputeBoundingBoxStatsDirect.cpp:81 — A NaN bound (ComputeFeatureBoundsFilter writes NaN rows for empty Features) goes to std::floor and a cast to usize, which is undefined behavior.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M08.ComputeBoundingBoxStatsFilter#8 -
L37 · MINOR · CreatePythonSkeletonFilter · CreatePythonSkeletonFilter.cpp:108 — A trailing separator in Existing Plugin Location gives an empty plugin name. Files go to the wrong folders before the filter fails with -2000.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M10.CreatePythonSkeletonFilter#4 - L38 · MINOR · ExecuteProcessFilter · ExecuteProcess.cpp:169 — The argument parser keeps a leading space after a quoted argument or a double space.
"/a b/prog" --helpgives the token ' --help'. (6.5.171 errata: KI-080)ExecuteProcessFilter#1— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L39 · MINOR · FeatureFaceCurvatureFilter · CalculateTriangleGroupCurvatures.cpp:226 — A Feature face of one triangle makes the patch code throw std::runtime_error. The whole filter fails with -2. (6.5.171 errata: KI-013)
FeatureFaceCurvatureFilter#6— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 -
L40 · MINOR · FlyingEdges3DFilter · FlyingEdges3D.cpp:88 —Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M15.auto triangleGeom = getDataRefAs<TriangleGeom>(...)copies the geometry. The destructor of the copy sends a false DataRemovedMessage for the live geometry id.FlyingEdges3DFilter#7 -
L41 · MINOR · LabelTriangleGeometryFilter · LabelTriangleGeometry.cpp:38 — The filter deletes Element Neighbors and Elements Containing Vert even when they existed before it ran. Preflight does not declare the deletion.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M16.LabelTriangleGeometryFilter#2 -
L42 · MINOR · MapPointCloudToRegularGridFilter · MapPointCloudToRegularGridFilter.cpp:362 — With Use Mask Array off, preflight creates a root DataArray 'temp_mask'. An existing object with that name makes the filter fail.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M17.MapPointCloudToRegularGridFilter#5 - L43 · MINOR · ReadDREAM3DFilter · ReadDREAM3DFilter.cpp:104 — An Include List path that is not in the file gives no warning. Only its ancestors are imported, as empty groups. (6.5.171 errata: KI-081)
ReadDREAM3DFilter#1— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L44 · MINOR · ReadStlFileFilter · ReadStlFile.cpp:62 — A corrupt binary STL triangle count (0x7FFFFFFF) resizes the lists before the file-size check. This allocates tens of GB or fails with bad_alloc. (6.5.171 errata: KI-050)
ReadStlFileFilter#4— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L45 · MINOR · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:740 — cellDims = pointDims - 1 has no minimum of 1. A valid 2D file (DIMENSIONS 10 10 1) fails with -260, and DIMENSIONS 0 underflows. (6.5.171 errata: KI-083)
ReadVtkStructuredPointsFilter#2— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 -
L46 · MINOR · RenameDataObjectFilter · RenameDataAction.cpp:76 — With Allow Overwrite on, the rename fails with -6601 when any ancestor has the new name, but no sibling would be overwritten.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M26.RenameDataObjectFilter#3 -
L47 · MINOR · RenameDataObjectFilter · RenameDataAction.cpp:146 — RenameDataAction::clone() drops m_Overwrite. Latent, because normal execution moves actions.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M27.RenameDataObjectFilter#5 -
L48 · MINOR · SetImageGeomOriginScalingFilter · UpdateImageGeomAction.cpp:63 — UpdateImageGeomAction::clone() drops m_CenterOrigin. Latent, because normal execution moves actions.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M28.SetImageGeomOriginScalingFilter#2 -
L49 · MINOR · SetImageGeomOriginScalingFilter · SetImageGeomOriginScalingFilter.cpp:126 — The 'Image Geometry [After Update]' preflight value ignores Set Origin, Set Spacing and the center-origin option.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M21.SetImageGeomOriginScalingFilter#3 -
L50 · MINOR · WriteStlFileFilter · WriteStlFile.cpp:610 — When the face count is an exact multiple of the per-file maximum, the filter writes one extra, empty STL file.Moved to BUG: Fix MINOR defects found by the filter sweep and reviews #1917 item M22.WriteStlFileFilter#3 - L51 · MINOR · WriteVtkRectilinearGridFilter · WriteVtkRectilinearGridFilter.cpp:63 — 6- or 9-component DataArrays are written as SCALARS, outside the 1 to 4 components of legacy VTK. The values are correct. (6.5.171 errata: KI-082)
WriteVtkRectilinearGridFilter#5— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L52 · MINOR · WriteVtkStructuredPointsFilter · WriteVtkStructuredPointsFilter.cpp:62 — 6- or 9-component DataArrays are written as SCALARS, outside the 1 to 4 components of legacy VTK. The values are correct. (6.5.171 errata: KI-082)
WriteVtkStructuredPointsFilter#2— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915
OrientationAnalysis (4 findings: 3 open, 1 fixed)
WRONG_DATA (4: 3 open, 1 fixed)
- L53 · WRONG_DATA · EBSDSegmentFeaturesFilter · SegmentFeatures.cpp:911 — With Is Periodic on and Neighbor Scheme = All, the shared SegmentFeatures code does not join X/Y-wrapped diagonal neighbors in the next Z slice. Two matching cells stay in different Features.
EBSDSegmentFeaturesFilter#2— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L54 · WRONG_DATA · ReadH5OimDataFilter · IEbsdOemReader.hpp:88 — The OIM and Esprit readers ignore the stacking order of Scan Names. High to Low stacks the scans in Low to High Z order. (6.5.171 errata: KI-011)
ReadH5OimDataFilter#3— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L55 · WRONG_DATA · WriteINLFileFilter · WriteINLFile.cpp:307 — The data rows write UnknownSymmetry for every Laue class except Cubic_High and Hexagonal_High, but the header maps all classes. The default branch of mapCrystalSymmetryToTslSymmetry also returns the wrong enum. (6.5.171 errata: KI-012)
WriteINLFileFilter#5— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L56 · WRONG_DATA · WriteStatsGenOdfAngleFileFilter · WriteStatsGenOdfAngleFile.cpp:31 — Delimiter = Colon writes a double quote (") between values, under a 'Colon delimited' header. (6.5.171 errata: KI-015)
WriteStatsGenOdfAngleFileFilter#2— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915
ImageProcessing (7 findings: 4 open, 3 fixed)
CRASH (1: open)
- L57 · CRASH · ReadImageFilter · ReadImage.cpp:389 — A multi-page TIFF with an RGB page 0 and a grayscale page 1 makes the copy callback read past the end of the narrower page buffer. The -2007 check runs only after the read. (6.5.171 errata: KI-053)
ReadImageFilter#2— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915
WRONG_DATA (4: 1 open, 3 fixed)
- L58 · WRONG_DATA · MaximumProjectionImageFilter · ImageProcessingFilterUtilities.hpp:775 — With Perform In-Place on, the shared helper deletes the original geometry. Attribute Matrices other than Cell Data (for example Cell Feature Data) are lost, and warning -8343 does not name them. (6.5.171 errata: KI-009)
MaximumProjectionImageFilter#1— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L59 · WRONG_DATA · ReadNIfTIFileFilter · NiftiUtilities.cpp:249 — With Use Stored Affine Transform on, a negative diagonal term in the sform (LPS orientation) or qfac = -1 is ignored. The geometry is placed mirrored and warning -34750 is not given.
ReadNIfTIFileFilter#3— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L60 · WRONG_DATA · ReadNIfTIFileFilter · NiftiUtilities.cpp:220 — A NaN scl_slope or scl_inter counts as valid scaling. With Apply Scaling Transform on, the output is a float32 DataArray full of NaN.
ReadNIfTIFileFilter#4— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911 - L61 · WRONG_DATA · ReadVolumeGraphicsFileFilter · ReadVolumeGraphicsFileFilter.cpp:450 — The density DataArray is always float32. A .vgi that declares an unsigned 16-bit or 32-bit integer volume is read as float32 bytes without an error.
ReadVolumeGraphicsFileFilter#3— PR BUG: Fix 9 crash and wrong-data findings from the filter sweep (#1908) #1911
MINOR (2: open)
- L62 · MINOR · ReadImageStackFilter · ReadImageStack.cpp:386 — A slice with a different data type than slice 0 (uint8 and uint16) makes getDataRefAs<DataArray> throw. The user gets the generic error -2, not an error that names the slice. (6.5.171 errata: KI-051)
ReadImageStackFilter#6— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 - L63 · MINOR · StandardDeviationProjectionImageFilter · ImageProcessingFilterUtilities.hpp:784 — Same in-place helper as MaximumProjectionImageFilter: with Perform In-Place on, other Attribute Matrices of the geometry are deleted, and warning -8343 lists only Cell Data arrays. (6.5.171 errata: KI-009)
StandardDeviationProjectionImageFilter#2— PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915
Found in the Feature Attribute Matrix clearing review (L64 to L72: 7 open, 2 moved)
These findings come from the review of branch topic/correct_feature_am_updates, and each line was checked on develop 10e4a07.
CRASH (1: moved to #1863)
-
L64 · CRASH · CropEdgeGeometryFilter · CropEdgeGeometry.cpp:483 — Preflight does not check that the Edge Attribute Matrix has one tuple per edge, or that the Vertex Attribute Matrix has one tuple per vertex. Execute copies both by index (also at line 463), so an Edge Attribute Matrix with 5 tuples for 10 edges is read out of bounds when edge 8 is kept. (related: BUG: C03: Element DataArray tuple count not checked in 21 filters #1863 and BUG: C09: Preflight throws in 27 filters #1869— moved to BUG: C03: Element DataArray tuple count not checked in 21 filters #1863CropEdgeGeometryFilter#3, different defects)CropEdgeGeometryFilter#4
WRONG_DATA (1: moved to #1867)
-
L65 · WRONG_DATA · ApplyTransformationToGeometryFilter · GeometryTransformation.cpp:530 — With Transformation Type = No Transformation and Save Transformation Matrix on, execute returns before it writes the matrix (line 574). The saved 4x4 array is all zeros, not identity. A later Pre-Computed transform with this array moves every vertex to (0, 0, 0). (related: BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters #1867— moved to BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters #1867ApplyTransformationToGeometryFilter#1, a different No Transformation defect)ApplyTransformationToGeometryFilter#13
MINOR (7: open)
- L66 · MINOR · SamplingUtils · SamplingUtils.hpp:50 — The -602 message of Sampling::RenumberFeatures (Crop Geometry (Image) and Resample Data with Renumber Features on) says the Feature count comes from the Feature Ids array and names the source array. The count comes from the Feature Attribute Matrix and the value from the destination array. It also prints to std::cout, and -600 and -602 are reused in ScalarSegmentFeatures.cpp.
SamplingUtils#1 - L67 · MINOR · SamplingUtils · SamplingUtils.hpp:38 — Sampling::RenumberFeatures reads the destination Feature Ids one value at a time. With an out-of-core store this is one cache lookup per cell. RemoveInactiveObjects already reads the same array in chunks with copyIntoBuffer.
SamplingUtils#2 - L68 · MINOR · Examples · basic_ebsd_ipf.ipynb:33 — 11 code cells of the notebook are not valid Python, because the module prefix is missing (
data_structure = .nxDataStructure()). The other 7 notebooks parse. No test runs the notebooks.Examples#1 - L69 · MINOR · Docs · EBSDSegmentFeaturesFilter.md:98 — "Example Pipelines" lists name pipelines that do not exist, for example "INL Export" on 9 pages. A name match finds 86 of 148 listed names, on 43 of 69 pages, with no pipeline file of that name. Some are only spelling differences.
Docs#1 - L70 · MINOR · Pipelines · ExtractFeatureBoundaries2D.d3dpipeline:25 — Shipped pipelines and Python scripts use absolute paths from developer machines (
/Users/mjackson/...). The same is in AppendImageGeometry.d3dpipeline:277, ebsd_segment_pilot.d3dpipeline:10 and 119, Combine_STL_Files.py:19 and convert_pipeline.py:6. None is a registered test, so the user gets "file does not exist".Pipelines#1 - L71 · MINOR · Pipelines · ImportEdaxOIMData.d3dpipeline:35 — The pipeline reads
Data/Hikari_Ni_Sequence.h5, which is in no Data Archive file and no test data. It is not a registered test. The Python version inexamples/pipelines/Incompletealso uses old parameter names.Pipelines#2— PR BUG: Validate EBSD reader headers, scans and slice ranges #1967 → combined into BUG: Combine the EBSD fixes that need the next EbsdLib release #1973 - L72 · MINOR · TestUtils · OrientationAnalysisTestUtils.hpp:60 — Eight filter handles are declared but no file uses them (for example k_CropImageGeometryFilterHandle; k_FindNFeaturePhasesFilterHandle and k_FindNeighborsFilterHandle also use old filter names). A reader thinks a test depends on these filters.
TestUtils#1
Moved from #1899 and found while reviewing PR #1915 (L73 to L81: 9 open)
Items L73 to L75 come from #1899. Items L76 to L81 were found while reviewing PR #1915. Each line was checked on develop a7dffc4 (2026-11-04), and the links use that commit.
Moved from #1899: WRONG_DATA (2) and ERROR (1)
- L73 · WRONG_DATA · GrayscaleDilate, GrayscaleErode, GrayscaleMorphologicalOpening, GrayscaleMorphologicalClosing, WhiteTopHat, BlackTopHat, MorphologicalGradient (ImageProcessing) · MorphologyEngine.hpp:384 — On a 2D image (Z = 1) with the Annulus kernel and radius
{0, 0, r}(r > 0), every kernel offset is out of plane, so the output is a constant (dilate gives the type minimum, erode gives the type maximum, the gradient giveslowest - max, which is 1 for uint8) and not a copy of the input. (was BUG: Fix DOC and comment defects. #1899 item D01)- The kernel is not empty, because the Annulus with
rx = ry = 0keeps only the offsets(0, 0, dz)withdz != 0. So the copy-through checksse.offsets.empty()do not catch it. - Grayscale routes with this problem:
Morphology2DBlockBody,MorphGradient2DBlockBody,MorphDirect,MorphGradientDirectandApplyMorphologyCompositePipeline. - Probe on a
{7, 3, 7}uint8 image: Dilate gives 0, Erode gives 255 (Direct and Scanline), Gradient gives 1, Opening gives 0 and Closing gives 255. The control kernel Annulus{0, 0, 0}copies the input on every route. - Suggested fix: when Z = 1, drop the offsets with
dz != 0before the empty-kernel check on each grayscale route. - The binary routes had the same problem. BUG: Fix 18 filter defects introduced in the 6.5.171 port #1900 fixed them on develop, and that fix can be used as a model.
- The kernel is not empty, because the Annulus with
- L74 · WRONG_DATA · FeatureFaceCurvatureFilter · CalculateTriangleGroupCurvatures.cpp:313 — With Use Normals for Curve Fitting on, the cubic fit has 7 unknowns, but the code does not check that the patch has at least 7 triangles, so a small patch gives an underdetermined least-squares fit and the curvature values are arbitrary, with no warning. (was BUG: Fix DOC and comment defects. #1899 item D02)
- The seed triangle is moved to the origin, so its row in the fit matrix is all zero. In practice the fit needs 7 triangles other than the seed.
- The quadratic fit (option off, 3 unknowns) has the same problem when the patch has only 2 triangles. On develop, only a patch with fewer than two valid triangles is marked invalid (lines 231-236).
- L75 · ERROR · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:1114 — The SCALARS component count is read with
std::atoi, so a bad value is not detected:abcor0gives 0 components, a negative value wraps to a very largeusize, and the reader then parses the next header from data bytes and fails with an unrelated error. (was BUG: Fix DOC and comment defects. #1899 item D03)- Suggested fix: parse the count with
StringInterpretationUtilities::Convert<usize>and reject a count less than 1 with a clear error.
- Suggested fix: parse the count with
Found while reviewing PR #1915: CRASH (1) and WRONG_DATA (3)
- L76 · CRASH · ApplyTransformationToGeometryFilter · ImageRotationUtilities.cpp:83 — With Transformation Type = Manual Transformation Matrix or Pre-Computed Transformation Matrix (4x4), a matrix with a zero column (for example a zero X column) gives an output spacing of 0 on that axis. The output dimension is then range / 0, which is inf or NaN. The cast of that value to
usizeis undefined behavior and gives a very large or random dimension, so the allocation can fail. Preflight (GeometryTransformation.cpp:229) does not check for a singular matrix. BUG: C14: Parameter values not validated in preflight in 65 filters #1873 item 9 covers only the Scale type. RotateSampleRefFrameFilter uses the same code. - L77 · WRONG_DATA · AlignSectionsFeatureCentroidFilter · AlignSectionsFeatureCentroid.cpp:136 — With Use Reference Slice on and Store Alignment Shifts on, the Relative Shifts array holds the shift relative to the reference slice. These are the same values as the Cumulative Shifts array (line 183; Scanline lines 387-391). The filter page says "relative to previous shift" (AlignSectionsFeatureCentroidFilter.md:59), and the Align Sections (List) page says to use this array as input (AlignSectionsListFilter.md:59). Align Sections (List) with Input Array Type = Relative adds the values again, so every shift from row 2 on is wrong.
- L78 · WRONG_DATA · AlignSectionsListFilter · Align_Sections_Backwards_Compatibility.d3dpipeline:91 — The example pipeline imports the 116-row 6.5.171 shift file (
Alignment_By_Misorientation_Shifts.txt) for a 117-section volume, with no zero row 0. With Input Array Type = Cumulative, Align Sections (List) applies row i to section 116 - i (AlignSectionsList.cpp:60), but row i of the file holds the shift of section 115 - i. So sections 1 to 115 get the shift of the section below them, section 0 gets no shift, and row 0 is not used. The "Note on Legacy Files" (AlignSectionsListFilter.md:55) does not tell users to add a zero row 0. Preflight gives no error because the row-count check runs only for Relative (AlignSectionsListFilter.cpp:119, tracked in BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters #1867). When BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters #1867 is fixed, this pipeline fails with -8943 until the file gets its row 0. - L79 · WRONG_DATA · ReadImageFilter · ReadImage.cpp:363 — For a multi-page TIFF, the code checks only the byte count of each page segment against page 0 (lines 310-311 and 363-366). A page with the same dimensions and the same bytes per pixel but a different layout passes. Example: page 0 is uint8 RGBA (4 bytes per pixel) and page 1 is float32 grayscale (4 bytes per pixel). The float bytes of page 1 are copied as four uint8 components (lines 389-393), with no error. This is not item L57, where the byte counts differ.
Found in the second review of PR #1915: WRONG_DATA (2)
- L80 · WRONG_DATA · AlignSectionsFeatureCentroidFilter · AlignSectionsFeatureCentroid.cpp:144 — An Image Geometry with an X or Y spacing of 0 (Create Image Geometry does not reject it) makes each centroid difference divided by the spacing NaN or ±inf. The cast of that value to int64 (lines 136-145, 197-204 and 337-345) is undefined behavior, so the shifts have undefined values. PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 gives an empty slice (NaN centroid) a zero shift, but it does not handle a zero spacing.
- L81 · WRONG_DATA · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:825 — With Read Point Data on, the point Image Geometry uses the file's DIMENSIONS as its cell dimensions and the file's ORIGIN as its origin. Point i is stored in a voxel whose center is ORIGIN + (i + 0.5) × SPACING, so every point value is half a spacing away from its VTK position on every axis. Example: DIMENSIONS 3 3 3, ORIGIN 2 6 10, SPACING 2 6 4. The first point is at (2, 6, 10), but its voxel center is (3, 9, 12). PR BUG: Fix 21 filter defects ported from 'SIMPL' and 'DREAM3D' #1915 centers an axis with one point on its VTK position, but does not change axes with more than one point.
Found while reviewing PR #1923 (L82: open)
Item L82 was found while reviewing PR #1923. It was checked on develop a7dffc4 (2026-11-05), and the links use that commit.
WRONG_DATA (1)
- L82 · WRONG_DATA · Dream3dIO (full import of a DREAM.3D 6.x file) · Dream3dIO.cpp:792 — When a DREAM.3D 6.x file is imported with preflight off (for example
DREAM3D::ImportDataStructureFromFile(path, false)),readLegacyStringArraymakes each StringDataArray withStringArray::CreateWithValuesand ignores the return value. The array gets one tuple for each string. When the string count is not equal to the tuple count of its Attribute Matrix,AttributeMatrix::canInsertrejects the array (AttributeMatrix.cpp:103),CreateWithValuesreturnsnullptr, and the import succeeds without the array. There is no error and no warning.- With preflight on, the same file keeps the array, but with a tuple count that is different from its Attribute Matrix (BUG: Legacy StringArray tuple count differs from its Attribute Matrix after import #1925).
- Suggested fix: when
CreateWithValuesreturnsnullptr, return an error that names the array, the string count and the tuple count of the Attribute Matrix. Use the same rule as the fix for BUG: Legacy StringArray tuple count differs from its Attribute Matrix after import #1925, so that the two import modes agree.
Found after 2026-11-05 (L83 to L98: 15 open, 1 not a defect)
Items L83 to L98 were added after 2026-11-05. Most of them come from the filter sweep and say to fix the defect during the V&V of that filter.
CRASH (6: 5 open, L92 not a defect)
- L85 · CRASH · ComputeNeighborhoodsFilter · ComputeNeighborhoodsFilter.cpp:153 — Nonfinite Multiples of Average or Search Radius corrupts derived radii or reaches preview integer conversion. Fix during this filter's V&V. (origin: sweep)
- L86 · CRASH · DBSCANFilter · DBSCANFilter.cpp:141 — NaN Epsilon passes filter preflight before grid sizing. This is the separate V&V preflight gap described in BUG: DBSCAN algorithms use an Epsilon of 0, negative or NaN when called without the filter #1887, not a duplicate of its direct-call repair. (origin: sweep)
- L89 · CRASH · WritePoleFigureFilter · WritePoleFigureFilter.cpp:201 — Image Size 1 permits invalid discrete indices, while excessive image dimensions overflow signed canvas arithmetic. Fix during this filter's V&V. (origin: sweep) — PR BUG: Fix input validation in four EBSD and mesh filters #1965, combined into BUG: Combine the EBSD fixes that need the next EbsdLib release #1973
- L90 · CRASH · WritePoleFigureFilter · WritePoleFigure.cpp:86 — Active Lambert Size and Number of Colors reach divisors, signed products or allocation shapes without count-domain validation. Fix during this filter's V&V. (origin: sweep) — PR BUG: Fix input validation in four EBSD and mesh filters #1965, combined into BUG: Combine the EBSD fixes that need the next EbsdLib release #1973
-
L92 · CRASH · ReadBinaryCTNorthstarFilter · ReadBinaryCTNorthstar.cpp:83 — Direct algorithm calls bypass the filter's subvolume-order check; a reversed X interval becomes an enormous row-buffer size. (origin: sweep)Not a defect: the filter's preflight rejects a reversed subvolume interval (-38712 for X), and an algorithm relies on its filter's preflight (see BUG: DBSCAN algorithms use an Epsilon of 0, negative or NaN when called without the filter #1887). - L98 · CRASH · ComputeNeighborhoodsFilter · ComputeNeighborhoods.cpp:116 — A valid large multiplier causes an enormous scan of empty bins after the useful neighborhood already covers the feature set. Investigate result-preserving traversal bounds during V&V; do not reject valid values merely to cap work. (origin: sweep)
WRONG_DATA (8: open)
- L83 · WRONG_DATA · ComputeKernelAvgMisorientationsFilter · ComputeKernelAvgMisorientationsFilter.cpp:171 — FromSIMPLJson selects the geometry from the ensemble CrystalStructures container instead of the cell data container. Equal-count geometries with different dimensions change the neighborhood and can produce 0 degrees instead of 5 degrees in the source-traced two-cell example. This filter has a V&V report; fix this defect during that filter's V&V and update its V&V package as applicable. Mechanism: C20d; cross-reference BUG: C20: Parameters not wired to filter behavior in 22 filters #1879; origin: sweep.
- L84 · WRONG_DATA · RegularizeZSpacingFilter · RegularizeZSpacingFilter.cpp:129 — Nonfinite New Z Spacing passes validation before dimension conversion. Fix during this filter's V&V. (origin: sweep)
- L87 · WRONG_DATA · ReadH5OinaDataFilter · ReadH5OinaDataFilter.cpp:326 — Nonfinite user Origin reaches geometry metadata. Fix during this filter's V&V. (origin: sweep) — PR BUG: Validate EBSD reader headers, scans and slice ranges #1967 → combined into BUG: Combine the EBSD fixes that need the next EbsdLib release #1973
- L91 · WRONG_DATA · MultiThresholdObjectsFilter · MultiThresholdObjectsDirect.cpp:72 — Comparison values and enabled custom TRUE/FALSE values can reach unsafe destination-type conversions. Cover nested thresholds and rounded integer limits during V&V; preserve documented valid fractional truncation. (origin: sweep)
- L93 · WRONG_DATA · RegularizeZSpacingFilter · RegularizeZSpacing.cpp:138 — Execute rereads bounds without repeating the established monotonicity check. Cover
direct calls andchanged files during V&V. (origin: sweep) Direct calls are not a defect (see BUG: DBSCAN algorithms use an Epsilon of 0, negative or NaN when called without the filter #1887); the reread file can still change after preflight. - L94 · WRONG_DATA · ComputeIPFColorsFilter · ComputeIPFColorsDirect.cpp:196 — Invalid or large finite reference directions are normalized unsafely in both algorithm paths. Fix during this filter's V&V. (origin: sweep)
- L95 · WRONG_DATA · RotateEulerRefFrameFilter · RotateEulerRefFrameFilter.cpp:90 — Nonfinite axes bypass the magnitude predicate and large finite axes overflow normalization. Fix during this filter's V&V. (origin: sweep)
- L97 · WRONG_DATA · ComputeSchmidsFilter · ComputeSchmidsFilter.cpp:164 — Nonfinite Loading Direction escapes preflight~~; direct algorithm calls also omit active Slip Plane and Slip Direction validation~~. Fix the three input checks in preflight during V&V. (origin: sweep) Direct calls are not a defect (see BUG: DBSCAN algorithms use an Epsilon of 0, negative or NaN when called without the filter #1887). Preflight checks Slip Plane and Slip Direction only for zero length (-13507, -13508); a nonfinite one is rejected only by the perpendicularity check.
ERROR (2: open)
- L88 · ERROR · ReadAngDataFilter · ReadAngDataFilter.cpp:116 — Nonpositive header grid dimensions reach unsigned geometry shapes. Fix during this filter's V&V. (origin: sweep) — PR BUG: Validate EBSD reader headers, scans and slice ranges #1967 → combined into BUG: Combine the EBSD fixes that need the next EbsdLib release #1973
- L96 · ERROR · RotateSampleRefFrameFilter · RotateSampleRefFrameFilter.cpp:197 — A valid large finite principal axis overflows normalization and is rejected as an invalid grid rotation. Fix during this filter's V&V. (origin: sweep)
Related issues
These open issues describe the same defect, or part of it. Fix the defect under its own issue, then tick the line here.
- BUG: Identify all duplicate vertices within coordinate ties #1783 BUG: Identify all duplicate vertices within coordinate ties
- BUG: Hierarchical smoothing moves fixed quadruple junctions #1793 BUG: Hierarchical smoothing moves fixed quadruple junctions
- BUG: Create AM Scan Paths creates hatches across exterior gaps #1795 BUG: Create AM Scan Paths creates hatches across exterior gaps
- BUG: Feature clustering RDF reference is not normalized to unit mass #1820 BUG: Feature clustering RDF reference is not normalized to unit mass
- BUG: Python plugin generator ignores the human-name parameter #1822 BUG: Python plugin generator ignores the human-name parameter
- DataStructure root node #1428 (open PR "DataStructure root node") does not change the
DataStructure::makePathnull dereference (CreateAMScanPathsFilter#7). - BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters #1867 BUG: C07: Preflight/execute or Direct/Scanline disagree in 53 filters. Its item
AlignSectionsListFilter#1(no row-count check for Cumulative) is why item L78 gives no error. - BUG: C20: Parameters not wired to filter behavior in 22 filters #1879 BUG: C20: Parameters not wired to filter behavior in 22 filters. Item
ApplyTransformationToGeometryFilter#10has the same cause as the false warnings 82009 to 82011 ("will be deleted") that Apply Transformation to Geometry gives for Translation and Scale with Linear Interpolation. One fix covers both.
Out of scope
- Findings in filters that have a V&V report are not in this issue. There are 7 such findings in 5 filters: CreateFeatureArrayFromElementArrayFilter, DBSCANFilter, GroupMicroTextureRegionsFilter, ReadEbsdPatternFileFilter, WriteDREAM3DFilter. A separate V&V branch handles them.
- Defects that follow a pattern shared by several filters. Each pattern has its own systemic issue (BUG: C01: Copy-paste index drift in 15 filters #1861 to BUG: C21: Wrong or misleading diagnostics in 10 filters #1880).
- Some findings match legacy DREAM3D 6.5.171 behavior (for example
AlignSectionsFeatureCentroidFilter#4,QuickSurfaceMeshFilter#4). The 6.5.171 errata lists that behavior as a defect, so fix it in DREAM3D-NX and say in the pull request that the output differs from 6.5.171.
Activity
imikejackson commentedon Nov 4, 2026
PR #1915 fixes the 21 items that are also DREAM.3D 6.5.171 errata entries: L04, L11, L12, L23, L28, L29, L30, L38, L39, L43, L44, L45, L51, L52, L54, L55, L56, L57, L58, L62 and L63. Each item has its own commit with a unit test that fails on
develop. They are marked "PR #1915" in the checklist and will be ticked when the PR merges.Design decisions made for these items:
imikejackson commentedon Nov 4, 2026
This issue now holds CRASH, WRONG_DATA and ERROR defects. 15 MINOR items that no pull request references (L31-L37, L40-L42, L46-L50) moved to #1917; their lines stay here, struck through, with the new item number. New items L73-L75 came from #1899 (2 WRONG_DATA, 1 ERROR) and L76-L79 were found while reviewing #1915 (1 CRASH, 3 WRONG_DATA). MINOR items that a pull request references (#1913, #1915) stay here.
[-]BUG: Fix one-off defects found by the filter sweep[/-][+]BUG: Fixes silent WRONG_DATA and CRASH bugs[/+]BUG: Write the plugin human name into generated Python plugins
REV: ProjectionImageFilters - Keep only the in-place warning fix
REV: AlignSectionsList - Ignore row 0 of the shift file again
REV: AlignSectionsFeatureCentroid - Give an empty slice a zero shift
REV: ReadImageStack - Check the slice data type where the slice is read
REV: ImageRotationUtilities - Use the classified source axis for grid…
REV: ReadVtkStructuredPoints - Center a plane or line on its VTK posi…
REV: ReadImage - State only what the multi-page TIFF checks compare
BUG: Copy PadImageGeometry Cell Data when an enabled axis has no padding
BUG: AlignSectionsFeatureCentroid - Shift the top section with a nonz…
88 remaining items
BUG: WriteStatsGenOdfAngleFile - Write a colon when the Colon delimit…
BUG: ReadImage - Reject a TIFF page with a different pixel layout bef…
BUG: ProjectionImageFilters - Add Copy Non-Cell Attribute Matrices an…
BUG: ReadImageStack - Report a slice with a different data type inste…
REV: ProjectionImageFilters - Keep only the in-place warning fix
REV: AlignSectionsList - Ignore row 0 of the shift file again
REV: AlignSectionsFeatureCentroid - Give an empty slice a zero shift
REV: ReadImageStack - Check the slice data type where the slice is read
REV: ImageRotationUtilities - Use the classified source axis for grid…
REV: ReadVtkStructuredPoints - Center a plane or line on its VTK posi…
REV: ReadImage - State only what the multi-page TIFF checks compare
REV: AlignSectionsFeatureCentroid - Reject an out-of-range Reference …
BUG: Reject legacy string arrays whose count differs from their Attri…
BUG: Fix 21 filter defects ported from SIMPL and DREAM3D (#1915)
BUG: Reject legacy string arrays whose count differs from their Attri…