Repository navigation
REL: EbsdLib v3.1.4 Official Release - #86
Merged
imikejackson merged 1 commit intoNov 13, 2026
Merged
imikejackson merged 1 commit into
imikejackson merged 1 commit into
Conversation
This was referenced Nov 13, 2026
Closed
Closed
Closed
Closed
This was referenced Nov 13, 2026
Open
Open
imikejackson
force-pushed
the
topic/next_release_fixes
branch
from
November 13, 2026 15:31
1b33074 to
069f421
Compare
imikejackson
force-pushed
the
develop
branch
from
November 13, 2026 15:35
40bbda6 to
34844ed
Compare
Fixed in this release: BUG: Download the test data from the EbsdLib archive site in a subdirectory build BUG: Report the slice reader's error from H5CtfVolumeReader::getPhases TEST: Combine the LaueOpsTest additions from the merged branches TEST: Combine the AngImportTest additions from the merged branches BUG: Report an error for a short ANG LatticeConstants or hklFamilies line BUG: Reject an HDF5 lattice constants dataset that does not hold 6 values BUG: Validate the pattern dataset in the Esprit and OIM HDF5 readers BUG: Report an error when an ANG header number cannot be parsed DOC: Document the unit-length preconditions of orientation conversions BUG: Clamp the quaternion scalar part before acos() in conversions BUG: Reject non-positive Lambert projection and pole figure dimensions BUG: Reject an h5ebsd slice that is larger than the volume ENH: Add a range-checked LaueOps lookup by crystal structure BUG: Reject invalid grid header values in the CTF and CPR readers BUG: Report an error when a .cpr file defines no phases COMP: Link canvas implementation into EbsdLib tests BUG: Prevent clipping in ODF section axes BUG: Preserve ODF glyphs and space axis labels ENH: Refine ODF section annotations BUG: Reject invalid ODF section grids BUG: Correct ODF section input linearization ENH: Add standard ODF section compositor BUG: Validate ODF units and crop coverage ENH: Add ODF section preparation utilities BUG: Weight the random ODF baseline by each bin's in-ball volume ENH: Expose ODF bin in-ball fractions and count homochoric clamp fallbacks BUG: Remove obsolete axis orthorhombic LaueOps entry ENH: Add generator-taking overloads for symmetry randomization and MDF sampling BUG: Stop sampling ODF orientations from outside the homochoric ball BUG: Keep CalculateMDFData normalized when MDF weights exceed the bin count LIC: Update license for directional stats BUG: Load the embedded fonts once and check that each font loads PERF: Measure the pole figure label width on a 1x1 canvas BUG: Use one column count for a square-grid ANG file BUG: Report an error when an ANG h5ebsd slice cannot be read BUG: Set error messages in H5OIMReader and H5EspritReader (BlueQuartzSoftware#69) BUG: Map space groups 1-230 to the correct Laue class (BlueQuartzSoftware#67) CI: Update to macOS 15 Build Bots (BlueQuartzSoftware#68)
imikejackson
force-pushed
the
topic/next_release_fixes
branch
from
November 13, 2026 15:37
069f421 to
88fb005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch combines every open EbsdLib fix branch except #62 (HDF5 2.x) into one branch for the next EbsdLib release, so that simplnx can build and test against one EbsdLib commit instead of many branches. It is the EbsdLib side of BlueQuartzSoftware/simplnx#1973, which builds and passes its full test suite against this branch.
Each original pull request is merged with
--no-ff, so its commits and history are kept. The original pull requests are closed with a link to this one.Merged pull requests
Conflict resolutions
Source/EbsdLib/Utilities/PoleFigureCompositor.cpp(PERF: Measure the pole figure label width on a 1x1 canvas #71 and BUG: Load the embedded fonts once and check each font load #74): the label width is measured on a 1x1 canvas (PERF: Measure the pole figure label width on a 1x1 canvas #71) and the font is loaded withfonts::LoadEmbeddedFont(BUG: Load the embedded fonts once and check each font load #74).Source/EbsdLib/LaueOps/LaueOps.cpp(BUG: getFZQuat returns one FZ quaternion for every equivalent orientation #64/BUG: Load the embedded fonts once and check each font load #74 and ENH: Standard ODF section images and in-ball ODF sampling #60): include lists only; the union of both is kept.Source/Test/AngImportTest.cpp(BUG: Report an error when an ANG h5ebsd slice cannot be read #72, BUG: Use one column count for a square-grid ANG file #73, BUG: Report an error when an ANG header number cannot be parsed #82, BUG: Report an error for a short ANG LatticeConstants or hklFamilies line #85) andSource/Test/LaueOpsTest.cpp(ENH: Standard ODF section images and in-ball ODF sampling #60, ENH: Add a range-checked LaueOps lookup by crystal structure #77): the automatic merge interleaved the helper functions that the branches add, so each file was rebuilt fromdevelopplus each branch's additions (commits "TEST: Combine the ... additions"). AngImportTest has 15 test cases (7 + 1 + 5 + 1 + 1) and LaueOpsTest 27 (23 + 3 + 1).Source/Test/CMakeLists.txt: union of the new test files.[11]axis-orthorhombic entry fromGetAllOrientationOps().GetOrientationOpsFromCrystalStructure()from ENH: Add a range-checked LaueOps lookup by crystal structure #77 already returns null for 11, so the two agree.New fix on this branch
H5CtfVolumeReader::getPhases()printed tostd::coutand returned no phases with error code 0 when the slice header could not be read, for example for a phase with a LatticeConstants dataset that does not hold 6 values (BUG: Reject an HDF5 lattice constants dataset that does not hold 6 values #84). It now sets the slice reader's error code and message, asH5AngVolumeReader::getPhases()does. simplnx uses this message in its Read H5EBSD error. New test:H5LatticeConstantsTest::VolumeReaderGetPhases(fails without the change:0 == -90350).When EbsdLib was added as a subdirectory (simplnx with
SIMPLNX_USE_LOCAL_EBSD_LIB=ON), it kept the parent project'sDATA_ARCHIVE_WEB_SITE, which points to the simplnx archive site. Every EbsdLib test-data download failed with HTTP 404, soPoleFigureCompositorTest::All_Laue_ClassesandDirectionalStatsTest:AverageOrientationfailed. EbsdLib now uses its own variable,EBSDLIB_DATA_ARCHIVE_WEB_SITE. It takesDATA_ARCHIVE_WEB_SITEonly when EbsdLib is the top-level project, so a standalone build bot that setsDATA_ARCHIVE_WEB_SITEkeeps working.API changes for callers
LaueOps::GetOrientationOpsFromSpaceGroupNumberwas renamedGetLaueOpsFromSpaceGroupNumberby BUG: Map space groups 1-230 to the correct Laue class #67, which is already ondevelop. simplnx#1973 uses the new name.LaueOps::GetOrientationOpsFromCrystalStructure()(ENH: Add a range-checked LaueOps lookup by crystal structure #77),EbsdHeaderEntry::hasParseError()(BUG: Report an error when an ANG header number cannot be parsed #82), and the ODF APIs of ENH: Standard ODF section images and in-ball ODF sampling #60.LaueOpsconstructor and removesGetAllOrientationOps()[11].Test Plan
ci-linux-x64): fullctestpasses, 516/516, run serially.topic/next_ebsdlib_fixesbuilt withSIMPLNX_USE_LOCAL_EBSD_LIB=ONagainst this branch and H5Support v1.0.14: full simplnx suite passes on Linux x64 Release (3972/3972; OrientationAnalysis 520/520). No simplnx exemplar result changed.x64-windows-v143), built as a subdirectory of simplnx#1973: builds with no warnings in EbsdLib; EbsdLib tests pass 516/516, with both test archives downloaded from the EbsdLib archive site.DATA_ARCHIVE_WEB_SITEwhen it is set.The
bluequartz-skillsplugin skills were not available in this environment.After this merges
Release EbsdLib, update
simplnx-registry, then update the simplnx vcpkg files.🤖 Generated with Claude Code