Repository navigation
refactor(pages): consolidate island action submissions - #632
Merged
cpojer merged 1 commit intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React, Vue, Svelte, and Solid each duplicated island-form JSON submission and response handling. Extract
submitIslandActioninto the existingvoid/pages-cliententry and reuse it across all four adapters, including the existing action-error decoder.These HTTP submission and response rules are unlikely to differ across frameworks; sharing them ensures fixes apply consistently to every adapter.
The adapters retain their state updates, success timers, navigation, reloads, and Promise-based submission APIs. This removes 98 net production lines and adds 47 regression cases covering redirect precedence, validation, HTTP error classification, body decoding, usage-limit metadata, and request failures.
Validation:
vp run --no-cache test:all --maxWorkers=4passed: formatting, lint, package/playground builds, build-artifact checks, workspace typechecking, and 15,073 tests (31 skipped).