Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages virtual client entries import
void/pages-clientandvoid/pages-prefetch, but these modules are absent from the initial dependency crawl. Late optimization can trigger a full reload during hydration or interaction. Prebundle both entries at startup in the React, Vue, Svelte, and Solid adapters.Add integration coverage that runs the real Vite optimizer with dependency discovery disabled and checks that both runtime bundles exist before the first browser request. The React regression fails on the original configuration and passes with this change.
This addresses a prebundling gap found while investigating the prepublish browser timeout. The original timeout did not reproduce locally, so this does not establish its cause or attribute it to PR #632.
Validation on macOS with Node 24.22.1 and npm 12.2.1:
vp run build:all: 41 tasks passed.vp run check: 33 tasks passed.vp test run --maxWorkers=4: 15,077 tests passed; 31 skipped.Linux comparison of the original failing command (
VOID_PACKED_SUITE=full VOID_PACKED_PM=npm VOID_PACKED_FRAMEWORK=react VOID_PACKED_TOOLCHAIN=vite-plus node .github/scripts/packed-consumer.mjs):588703d4fa0ebb4d4aBoth ran in the same Ubuntu 24.04 Linux x64 container under emulation on an arm64 Mac, using Node 24.22.1, npm 12.2.1, and consumer Vite+ 1.4.0. The test and lockfile hashes matched; all 548 external dependency entries, versions, and integrity values matched. These were single runs, not a performance benchmark.
The subsequent full prepublish run on main
63b0d91ccalso passed the npm + Vite+ React browser check without this change. The original CI timeout has not been reproduced, and there is no failing-before/passing-after evidence that this PR resolves it.The before run's dev-server log shows
void/pages-prefetchandvoid/pages-clientoptimized separately, followed byoptimized dependencies changed. reloading. The after run has no such startup reload. This demonstrates the startup behavior change while both complete browser tests still pass.