Skip to content

ci: fix build_makefile-windows-cygwin job - #15536

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:build/msys2-deps
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:build/msys2-deps

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #14908.

@oech3

oech3 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

I did not test. But mingw-w64-ucrt-x86_64-libgit2-winhttp might work via Windows's cert.

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

Tested in #13784.

@xtqqczze xtqqczze changed the title wip! ci: fix build_makefile-windows-cygwin job ci: fix build_makefile-windows-cygwin job Oct 21, 2026
Comment thread .github/workflows/make.yml Resolved
Comment thread .github/workflows/make.yml Resolved
@xtqqczze
xtqqczze marked this pull request as ready for review October 21, 2026 13:01
@xtqqczze
xtqqczze marked this pull request as draft October 21, 2026 13:36
@xtqqczze

Copy link
Copy Markdown
Collaborator Author
upgrading msys2-runtime...
:: To complete this update all MSYS2 processes including this terminal will be closed. Confirm to proceed [Y/n] SUCCESS: The process with PID 7896 has been terminated.
Error: Process completed with exit code 1.

https://github.com/uutils/coreutils/actions/runs/39604842518/job/119238273017?pr=13784#step:7:56

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@oech3 we should be using msys2/setup-msys2 action?

@oech3

oech3 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

I want to avoid new action since it is slow to setup.

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

I guess we can just use pacman -Syu --noconfirm || true to avoid the step failing.

@oech3

oech3 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

We don't care about TOCTOU at here, but pacman -Syu --noconfirm pkg1 pkg2 ... is atomic.

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

We don't care about TOCTOU at here, but pacman -Syu --noconfirm pkg1 pkg2 ... is atomic.

I don't know, but I think we must perform full system update first.

@lazka

lazka commented Oct 21, 2026

Copy link
Copy Markdown

I can look into a PR if wanted.

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@lazka What we have in this PR works now, I've tested it in #13784

What @oech3 has queried is whether this can be done in one command, i.e. pacman -Syu --noconfirm pkg1 pkg2, or whether separate steps are better.

@lazka

lazka commented Oct 21, 2026

Copy link
Copy Markdown

the separate steps are sadly needed

@xtqqczze
xtqqczze marked this pull request as ready for review October 21, 2026 17:04
Comment thread .github/workflows/make.yml Resolved
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@lazka Thanks for confirming! I think we have everything we need here. Ideally, we'd use msys2/setup-msys2, but that can be addressed separately.

Comment thread .github/workflows/make.yml Resolved
Comment thread .github/workflows/make.yml Resolved
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)

@xtqqczze

This comment was marked as outdated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSYS job failing with invalid SSL certificate error

3 participants