Skip to content

tr: replace rustix socketpair with filedescriptor in test_stdin_is_socket - #13784

Draft
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:refactor-test_stdin_is_socket2
Draft

xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:refactor-test_stdin_is_socket2

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 6, 2026 •

Copy link
Copy Markdown
Collaborator

WIP: Depends on a new filedescriptor crate release to remove the patch.crates-io override.

@sylvestre

Copy link
Copy Markdown
Contributor

still a draft ?

@xtqqczze

xtqqczze commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

still a draft ?

I don't think we can take this with a patch.crates-io override?

@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch 2 times, most recently from fdc9982 to b06fa02 Compare August 7, 2026 21:41
@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/id/setgid is no longer failing!

@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch from b06fa02 to df258cd Compare August 8, 2026 08:48
@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch from df258cd to c466dae Compare August 23, 2026 22:45
@codspeed

codspeed Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 20.57%

2 warnings, 1 note

⚠️ 122 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 1 improved benchmark
✅ 400 untouched benchmarks
⏩ 70 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ CPU Simulation mv_force_overwrite 154.4 ms 128.1 ms +20.57%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:refactor-test_stdin_is_socket2 (52eae24) with main (aea67c0)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (fee61ff) during the generation of this report, so aea67c0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch 2 times, most recently from e1bfec4 to ced61cc Compare August 31, 2026 00:26
@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch 3 times, most recently from d936ce0 to e05ddcd Compare September 25, 2026 16:02
@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch 2 times, most recently from 3f209b8 to bca90ec Compare September 27, 2026 14:11
@xtqqczze

This comment was marked as resolved.

@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch from bca90ec to 727f0bc Compare October 1, 2026 11:16
@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch 4 times, most recently from 1d1646b to b8e13ec Compare October 21, 2026 08:15
@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch 4 times, most recently from 750bb9b to 2af7b58 Compare October 21, 2026 17:11
@xtqqczze xtqqczze self-assigned this Oct 27, 2026
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

Depends on #15536.

@xtqqczze xtqqczze closed this Oct 27, 2026
@xtqqczze xtqqczze reopened this Oct 30, 2026
@xtqqczze
xtqqczze force-pushed the refactor-test_stdin_is_socket2 branch from 2af7b58 to 52eae24 Compare October 30, 2026 16:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants