Repository navigation
Set PY_ESDK_CACHE in addition to EMSDK_CACHE - #826
Merged
Merged
Conversation
EMSDK_CACHE means something to Emscripten so we shouldn't use it. This allows us to migrate the name.
emmatyping
approved these changes
Nov 3, 2026
zware
approved these changes
Nov 3, 2026
hoodmane
added a commit
to python/cpython
that referenced
this pull request
Nov 3, 2026
Because Emscripten wants to own the environment variable EMSDK_CACHE. Required python/buildmaster-config#826 first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EMSDK_CACHE means something to Emscripten so we shouldn't use it. This allows us to migrate the name.
Needed for #826.