Repository navigation
gh-145805: Change EMSDK_CACHE to PY_EMSDK_CACHE - #160989
Merged
Merged
Conversation
Because Emscripten wants to own the environment variable EMSDK_CACHE. Requires python/buildmaster-config#826.
bedevere-app
Bot
added
awaiting review
type-feature
hoodmane
added
skip news
OS-emscripten
needs backport to 3.14
hoodmane
requested review from
AA-Turner,
JacobCoffee,
StanFromIreland,
ezio-melotti,
hugovk,
itamaro and
webknjaz
as code owners
October 30, 2026 22:00
emmatyping
approved these changes
Oct 31, 2026
Contributor
Author
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 8edfd23 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F160989%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we should leave the environment variable EMSDK_CACHE to Emscripten for its internal use. Requires python/buildmaster-config#826. Came up in emscripten-core/emscripten#28113.
python Platforms/emscripten run#145805