Repository navigation
Frame store screenshots with storeframe - #232
Merged
Merged
Conversation
The framing script moved into its own package, storeframe (https://github.com/andiwand/storeframe), shared with OpenDocument.droid. The lane now runs it on fastlane/frames/frames.json; the design file is unchanged apart from the 04-edit-lite alias, which used to be hard-coded in the script. The font ships with the package, so its copy here is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZWfrDqfHDPiWY7fcMg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
The screenshot framing script moved into its own package, storeframe (PyPI), shared by OpenDocument.ios, OpenDocument.droid and almucantar.
Changes
scripts/frame-screenshots.py; the screenshots lane runspython3 -m storeframe frame fastlane/frames/frames.json …instead.scripts/requirements.txtwithstoreframe==0.1.0(pinned); the release workflow installs it instead of Pillow.frames.jsonis unchanged except for"aliases": ["04-edit-lite"]on04-edit. That mapping used to be hard-coded in the script.Verification
ruby -c fastlane/Fastfile; no simulator run yet. The next screenshots run in CI is the real check.