Skip to content

Frame store screenshots with storeframe - #232

Merged
andiwand merged 1 commit into
mainfrom
storeframe
Nov 14, 2026
Merged

andiwand merged 1 commit into
mainfrom
storeframe

Conversation

@andiwand

@andiwand andiwand commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

The screenshot framing script moved into its own package, storeframe (PyPI), shared by OpenDocument.ios, OpenDocument.droid and almucantar.

Changes

  • Delete scripts/frame-screenshots.py; the screenshots lane runs python3 -m storeframe frame fastlane/frames/frames.json … instead.
  • Add scripts/requirements.txt with storeframe==0.1.0 (pinned); the release workflow installs it instead of Pillow.
  • frames.json is unchanged except for "aliases": ["04-edit-lite"] on 04-edit. That mapping used to be hard-coded in the script.
  • Remove the bundled Nunito copy; storeframe ships the same font file.
  • Update the docs and comments that pointed at the old script.

Verification

  • Framed the real captures, replicated to every store locale and with a lite capture added, using the old script and storeframe 0.1.0 from PyPI. Both produced the same file names and sizes.
  • iOS: 63 pictures (9 locales). The pixel differences are tiny: bezels are now proportional to the screen, and iPhone corners use the iPhone's continuous curve (the old script drew a Pixel-style corner).
  • Ran the lane command with ruby -c fastlane/Fastfile; no simulator run yet. The next screenshots run in CI is the real check.

The framing script moved into its own package, storeframe
(https://github.com/andiwand/storeframe), shared with OpenDocument.droid.
The lane now runs it on fastlane/frames/frames.json; the design file is
unchanged apart from the 04-edit-lite alias, which used to be hard-coded in
the script. The font ships with the package, so its copy here is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FW6WZWfrDqfHDPiWY7fcMg
@andiwand
andiwand merged commit c0cc270 into main Nov 14, 2026
3 of 4 checks passed
@andiwand
andiwand deleted the storeframe branch November 14, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant