Repository navigation
Write the screenshot samples with the sampledoc package - #231
Merged
Merged
Conversation
The samples the store screenshots open were generated by a 1,500 line script that the Android app carried a newer copy of. Both now take them from sampledoc (https://pypi.org/project/sampledoc/), pinned at 0.1.0 in scripts/requirements.txt next to storeframe. make-screenshot-documents.py stays as the entry point and writes the languages store_screenshots.LOCALES photographs. It refuses to run against a different sampledoc version than the pinned one. The samples are the same, byte for byte, as the old script wrote. screenshot-names.json now nests the languages under "languages" and carries the locale table, as on Android; ScreenshotMode reads the new layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZb2gUX4HQfKXWeZ3UQ
andiwand
force-pushed
the
use-sampledoc-package
branch
from
November 14, 2026 14:24
d7d1446 to
1a048c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
The samples the store screenshots open were written by
scripts/make-screenshot-documents.py. That was 1,500 lines of generator and translations, and OpenDocument.droid carried a newer copy of it. The generator now lives in its own repo, opendocument-app/sampledoc, and is published on PyPI assampledoc. This PR switches the app to it.scripts/requirements.txtpinssampledoc==0.1.0next tostoreframe(from Frame store screenshots with storeframe #232). The release workflow's screenshot job installs from it, and the file is part of that job's build cache key.scripts/make-screenshot-documents.pyis now a short wrapper with the same name,--languageoption and output folder (OpenDocumentReader/Samples), so the Fastfile is unchanged. It writes the 9 languagesstore_screenshots.LOCALESphotographs, the same set as before, and exits if the installedsampledocisn't the pinned version.screenshot-names.jsonchanges. The languages are now nested under"languages", and the file also carries the locale table, as on Android.ScreenshotMode.swiftdecodes the new format; it's a 5-line change.The samples are unchanged. I ran the old script and the new wrapper: all 81 files are byte-for-byte identical, and each language's names and search word match.
Tested locally:
xcodebuildof theODR Screenshotsscheme for the iOS Simulator: BUILD SUCCEEDEDI haven't run a screenshot capture; the release workflow's screenshot job is the first real run.
The Android change is opendocument-app/OpenDocument.droid#759.