Skip to content

Rename abi check rule to make sense #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwmcguir wants to merge 1 commit into from
+4 −1
Closed

Rename abi check rule to make sense #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/check-abi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ jobs:
# A failure can be accepted by a reviewer: leave an approval review on the
# PR head commit with the keyword abi-failure-approved in the review body.
check-abi:
name: check-abi-${{ matrix.base }}
# The name must not use matrix: a skipped job shows its name unexpanded.
# GitHub appends the matrix value, e.g. "check-abi (master)". Reviews
# without the keyword skip this job and show "ABI approval re-check".
name: ${{ github.event_name == 'pull_request_review' && 'ABI approval re-check' || 'check-abi' }}
runs-on: ubuntu-latest
if: >-
github.repository_owner == 'oneapi-src' &&
Expand Down
Loading