Skip to content

Rename abi check rule to make sense - #550

Closed
rwmcguir wants to merge 1 commit into
oneapi-src:masterfrom
rwmcguir:abi_check_job_name
Closed

rwmcguir wants to merge 1 commit into
oneapi-src:masterfrom
rwmcguir:abi_check_job_name

Conversation

@rwmcguir

Copy link
Copy Markdown
Contributor

Old rule appeared as skipped and was misleading with it's name so renaming it to not look invalid

Old rule appeared as skipped and was misleading with it's name
so renaming it to not look invalid

Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
@github-actions

Copy link
Copy Markdown

Level Zero loader ABI check

last-release (v1.35.0): ✅ no ABI problems. Report

Creating compatibility report ...
Binary compatibility: 100%
Source compatibility: 100%
Total binary compatibility problems: 0, warnings: 0
Total source compatibility problems: 0, warnings: 0

master (master): ✅ no ABI problems. Report

Creating compatibility report ...
Binary compatibility: 100%
Source compatibility: 100%
Total binary compatibility problems: 0, warnings: 0
Total source compatibility problems: 0, warnings: 0

Workflow run

If an ABI change is intended, a reviewer with write access can accept it: leave an approval review on the PR head commit with the keyword abi-failure-approved in the review body. That re-runs the check.

@rwmcguir rwmcguir left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abi-failure-approved

@rwmcguir

Copy link
Copy Markdown
Contributor Author

Closing: GitHub does not expand expressions in the name of a skipped job, so the rename cannot make the skipped review entry readable. Keeping the current workflow.

@rwmcguir rwmcguir closed this Oct 26, 2026
@rwmcguir
rwmcguir deleted the abi_check_job_name branch October 26, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant