Repository navigation
Fix Yamcs TLS verification setting on main - #1937
Merged
Merged
Conversation
Honor the configured TLS verification default on API, login, and token-renewal requests while retaining secure defaults and existing CA support. Add offline SDK regressions and bump main to 0.261.062. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the four incoming favicon commits and the Yamcs request-policy fix. Resolve version and release-note conflicts with hotfix version 0.261.064 and aligned documentation/test headers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issue
Refs #1934
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedApplication version: current main
0.261.063-> hotfix0.261.064. No deployer changes.Merged the four latest main favicon commits through
fdce7547e42a34b7e6d2bf72ec9947e8037e3619using merge commitcff96b7d5d6665713823eb67dcd92d2163fb8994. Preserved all incoming favicon changes and both sets of release notes, and aligned Yamcs documentation/test versions. No history rewriting or force push.Testing / validation
python .\functional_tests\test_yamcs_tls_verify.py— passed, 6 tests. The suite reproduced 27 failing subcases before the production fix.python -O .\functional_tests\test_yamcs_tls_verify.py— passed, 6 tests.python .\functional_tests\test_yamcs_action_plugin.py— passed, 14 tests.python .\functional_tests\test_yamcs_basic_auth.py— passed, 12 tests.python .\functional_tests\route_tests\test_route_blueprint_policy_inventory.py— passed, 6 tests.python .\functional_tests\route_tests\test_route_unauthenticated_policy_contract.py— passed, 4 tests.python .\functional_tests\route_tests\test_route_policy_test_coverage.py— passed, 2 tests.python .\functional_tests\test_docs_app_surface_coverage.py— passed, 7 checks; generated inventory remains current.python .\functional_tests\test_docs_site_quality.py— passed, 6 checks.python .\functional_tests\test_custom_favicon_persistence.py— passed, 4 fresh-process cases including normal/optimized Python and both import orders.python -m pytest .\ui_tests\test_custom_favicon_persistence.py -q— passed, 1 browser regression.python -m py_compile .\application\single_app\app.py .\application\single_app\config.py .\application\single_app\functions_yamcs_operations.py .\application\single_app\semantic_kernel_plugins\yamcs_plugin.py .\application\single_app\route_backend_plugins.py .\functional_tests\test_yamcs_tls_verify.py— passed.git --no-pager -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --check— passed; staged whitespace check also passed.All listed local checks were rerun after resolving the main merge. The same-named favicon files were run in separate pytest processes to avoid their module-name collection collision. The TLS suite uses real pinned Yamcs/Requests behavior with intercepted HTTP transport and blocked network access, covering login, renewal, CA precedence, secure defaults, authentication methods, overrides, and cleanup. No live telemetry-server retest or certificate installation was performed.
Promotion-policy gate: the existing
enforce-branch-flowworkflow requires PRs intomainto originate fromStaging. This requested direct main hotfix needs maintainer handling of that promotion requirement before merge. The workflow/protection policy has not been changed or bypassed.Documentation
Updated the Yamcs action reference/feature and added
docs/explanation/fixes/YAMCS_TLS_VERIFY_ENV_OVERRIDE_FIX.md. The existing Docker CA guide and certificate mechanism are unchanged.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No routes, authorization policies, frontend settings payloads, or browser assets were added by this fix. Verification remains enabled by default and failed verified requests are never retried insecurely.