Skip to content

Fix Yamcs TLS verification setting on main - #1937

Merged
Paul Lizer (paullizer) merged 2 commits into
mainfrom
paullizer-yamcs-tls-handling
Nov 17, 2026
Merged

Paul Lizer (paullizer) merged 2 commits into
mainfrom
paullizer-yamcs-tls-handling

Conversation

@paullizer

@paullizer Paul Lizer (paullizer) commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Honor the configured Yamcs TLS verification setting on runtime and connection-test requests even when an environment CA bundle is configured.
  • Apply request defaults before SDK login, retain them for token renewal, and close the session if login fails.
  • Keep verification enabled by default, preserve explicit request overrides, and leave existing CA support, deployment settings, and dependency versions unchanged.
  • This is the requested main-first hotfix; a separate Development port follows without promoting unrelated Development changes into main.

Linked issue

Refs #1934

Release Notes & Latest Features

  • New Feature
  • Bug Fix
  • UI Enhancement
  • Breaking Change
  • Internal only

Is this visible to end users?

  • Yes
  • No

Is this admin-facing (Admin Settings, governance, deployment, config)?

  • Yes
  • No

Should this become a Latest Feature card?

  • Yes
  • No
  • Already added

Screenshot needed for the card?

  • Yes
  • No
  • Attached

Version bump

  • application/single_app/config.py VERSION third segment bumped, or not needed because this is docs-only
  • deployers/version.txt bumped, or not needed because deployers/ was not changed

Application version: current main 0.261.063 -> hotfix 0.261.064. No deployer changes.

Merged the four latest main favicon commits through fdce7547e42a34b7e6d2bf72ec9947e8037e3619 using merge commit cff96b7d5d6665713823eb67dcd92d2163fb8994. Preserved all incoming favicon changes and both sets of release notes, and aligned Yamcs documentation/test versions. No history rewriting or force push.

Testing / validation

  • python .\functional_tests\test_yamcs_tls_verify.py — passed, 6 tests. The suite reproduced 27 failing subcases before the production fix.
  • python -O .\functional_tests\test_yamcs_tls_verify.py — passed, 6 tests.
  • python .\functional_tests\test_yamcs_action_plugin.py — passed, 14 tests.
  • python .\functional_tests\test_yamcs_basic_auth.py — passed, 12 tests.
  • python .\functional_tests\route_tests\test_route_blueprint_policy_inventory.py — passed, 6 tests.
  • python .\functional_tests\route_tests\test_route_unauthenticated_policy_contract.py — passed, 4 tests.
  • python .\functional_tests\route_tests\test_route_policy_test_coverage.py — passed, 2 tests.
  • python .\functional_tests\test_docs_app_surface_coverage.py — passed, 7 checks; generated inventory remains current.
  • python .\functional_tests\test_docs_site_quality.py — passed, 6 checks.
  • python .\functional_tests\test_custom_favicon_persistence.py — passed, 4 fresh-process cases including normal/optimized Python and both import orders.
  • python -m pytest .\ui_tests\test_custom_favicon_persistence.py -q — passed, 1 browser regression.
  • python -m py_compile .\application\single_app\app.py .\application\single_app\config.py .\application\single_app\functions_yamcs_operations.py .\application\single_app\semantic_kernel_plugins\yamcs_plugin.py .\application\single_app\route_backend_plugins.py .\functional_tests\test_yamcs_tls_verify.py — passed.
  • git --no-pager -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --check — passed; staged whitespace check also passed.

All listed local checks were rerun after resolving the main merge. The same-named favicon files were run in separate pytest processes to avoid their module-name collection collision. The TLS suite uses real pinned Yamcs/Requests behavior with intercepted HTTP transport and blocked network access, covering login, renewal, CA precedence, secure defaults, authentication methods, overrides, and cleanup. No live telemetry-server retest or certificate installation was performed.

Promotion-policy gate: the existing enforce-branch-flow workflow requires PRs into main to originate from Staging. This requested direct main hotfix needs maintainer handling of that promotion requirement before merge. The workflow/protection policy has not been changed or bypassed.

Documentation

  • Release notes updated, or not needed
  • Feature documentation updated, or not needed
  • Fix documentation updated, or not needed

Updated the Yamcs action reference/feature and added docs/explanation/fixes/YAMCS_TLS_VERIFY_ENV_OVERRIDE_FIX.md. The existing Docker CA guide and certificate mechanism are unchanged.

Security checklist

  • New Flask routes include @swagger_route(security=get_auth_security())
  • Settings sent to non-admin frontends use sanitize_settings_for_user()
  • Browser JavaScript is served from local SimpleChat static assets only; no CDN-hosted JS
  • No secrets, keys, connection strings, or local-only artifacts are included

No routes, authorization policies, frontend settings payloads, or browser assets were added by this fix. Verification remains enabled by default and failed verified requests are never retried insecurely.

Honor the configured TLS verification default on API, login, and token-renewal requests while retaining secure defaults and existing CA support. Add offline SDK regressions and bump main to 0.261.062.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the four incoming favicon commits and the Yamcs request-policy fix. Resolve version and release-note conflicts with hotfix version 0.261.064 and aligned documentation/test headers.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paullizer
Paul Lizer (paullizer) merged commit 273956c into main Nov 17, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants