Repository navigation
Fix Yamcs TLS verification setting on Development - #1938
Merged
Paul Lizer (paullizer) merged 1 commit intoNov 13, 2026
Merged
Conversation
Port the verified main Yamcs TLS request policy while retaining Development destination guards and personal credential status handling. Cover guarded login, renewal, secure defaults, explicit opt-out, and failed-login cleanup with offline SDK regressions. Bump Development independently to 0.261.442. Refs #1934. Main counterpart: #1937. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3e058c7c82ace5258eaebe7193a54e44dc46cbe0without importing main or unrelated changes. Explicitly disabled verification now survives Requests' environment CA merge for connection tests, initial login, API calls, and token renewal._credential_status_transportinterception. Replace the conditional pre-login wrapper instead of double-wrapping authenticated sessions; renew the three unchanged Cosmos owners' module reviews with real SDK evidence.0.261.441to0.261.442.Linked issue
Refs #1934.
Development counterpart of main PR #1937. This PR does not close the issue; the coordinating session will provide the consolidated issue update. No merge or deployment is requested.
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedApplication version: 0.261.442. No files under
deployers/changed.Testing / validation
The six ported methods reproduced 27 failing subcases on unpatched Development. The final suite adds Development-specific real-SDK HTTP 401/403/407 interception coverage. Transport is intercepted and DNS/socket access is blocked; no live telemetry endpoint was accessed and no CA was installed.
python .\functional_tests\test_yamcs_tls_verify.pypython -O .\functional_tests\test_yamcs_tls_verify.pypython .\functional_tests\test_yamcs_action_plugin.pypython .\functional_tests\test_yamcs_basic_auth.pypython -m pytest -p test_support.cosmos_network_guard functional_tests\test_outbound_destination_policy.py -qpython .\functional_tests\route_tests\test_route_blueprint_policy_inventory.pypython .\functional_tests\route_tests\test_route_unauthenticated_policy_contract.pypython .\functional_tests\route_tests\test_route_policy_test_coverage.pypython .\functional_tests\test_docs_app_surface_coverage.pypython .\functional_tests\test_docs_site_quality.pypython -m pytest -p test_support.cosmos_network_guard functional_tests\test_action_route_cosmos_response_contract.py functional_tests\test_plugin_routes_cosmos_contract.py -qpython .\scripts\check_cosmos_response_boundaries.py --refreshpython .\scripts\check_cosmos_response_boundaries.pypython -m py_compile application\single_app\config.py application\single_app\functions_yamcs_operations.py application\single_app\semantic_kernel_plugins\yamcs_plugin.py application\single_app\route_backend_plugins.py functional_tests\test_yamcs_action_plugin.py functional_tests\test_yamcs_basic_auth.py functional_tests\test_yamcs_tls_verify.pygit -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol --no-pager diff --checkgit -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol --no-pager diff --cached --checkNetwork-guard pytest commands used this PowerShell setup:
Additional existing-suite limitation:
python -m pytest -p test_support.cosmos_network_guard functional_tests\test_outbound_destination_policy.py functional_tests\test_action_personal_credentials.py::test_real_yamcs_sdk_handshake_and_proxy_transport_status -qproduced 57 passes and 7 setup errors. Those seven cases stop before the Yamcs path because the unchanged lifecycle fixture'sfunctions_action_catalogstub lacksbuild_action_planner_projection, imported byconfigure_action_credential_runtime(). No unrelated production/fixture changes were made to bypass it. The new focused TLS suite independently passes real-SDK status detection for all three HTTP authentication statuses across username/password, bearer, API key plus proxy Basic, proxy-only Basic, and NoAuth paths.Documentation
Updated the Yamcs action reference and feature documentation, added
docs/explanation/fixes/YAMCS_TLS_VERIFY_ENV_OVERRIDE_FIX.md, and added the0.261.442release note with non-closing issue/main-PR references.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No routes, route authorization policies, settings response shapes, browser assets, destination policies, or certificate/deployment mechanisms were added or changed. Every SDK request in the TLS policy matrix retains Development's guarded HTTP adapter, including constructor-time login. The wrapper-only proxy regression preserves Requests environment handling without relaxing Development's separate forward-proxy rejection policy.