Skip to content

Fix Yamcs TLS verification setting on Development - #1938

Merged
Paul Lizer (paullizer) merged 1 commit into
Developmentfrom
paullizer-yamcs-development-port
Nov 13, 2026
Merged

Paul Lizer (paullizer) merged 1 commit into
Developmentfrom
paullizer-yamcs-development-port

Conversation

@paullizer

Copy link
Copy Markdown
Collaborator

Summary

  • Port the verified Yamcs TLS-setting fix from main's functional commit 3e058c7c82ace5258eaebe7193a54e44dc46cbe0 without importing main or unrelated changes. Explicitly disabled verification now survives Requests' environment CA merge for connection tests, initial login, API calls, and token renewal.
  • Keep verification enabled by default, preserve explicit request overrides, and never retry insecurely. Existing organization CA support and deployment settings are unchanged.
  • Retain Development's outbound URL/address/redirect guards, action credential contracts, and _credential_status_transport interception. Replace the conditional pre-login wrapper instead of double-wrapping authenticated sessions; renew the three unchanged Cosmos owners' module reviews with real SDK evidence.
  • Add offline real-SDK regressions, update Yamcs docs/release notes, and independently bump Development from 0.261.441 to 0.261.442.

Linked issue

Refs #1934.

Development counterpart of main PR #1937. This PR does not close the issue; the coordinating session will provide the consolidated issue update. No merge or deployment is requested.

Release Notes & Latest Features

  • New Feature
  • Bug Fix
  • UI Enhancement
  • Breaking Change
  • Internal only

Is this visible to end users?

  • Yes
  • No

Is this admin-facing (Admin Settings, governance, deployment, config)?

  • Yes
  • No

Should this become a Latest Feature card?

  • Yes
  • No
  • Already added

Screenshot needed for the card?

  • Yes
  • No
  • Attached

Version bump

  • application/single_app/config.py VERSION third segment bumped, or not needed because this is docs-only
  • deployers/version.txt bumped, or not needed because deployers/ was not changed

Application version: 0.261.442. No files under deployers/ changed.

Testing / validation

The six ported methods reproduced 27 failing subcases on unpatched Development. The final suite adds Development-specific real-SDK HTTP 401/403/407 interception coverage. Transport is intercepted and DNS/socket access is blocked; no live telemetry endpoint was accessed and no CA was installed.

Exact command Result
python .\functional_tests\test_yamcs_tls_verify.py Passed: 7 methods
python -O .\functional_tests\test_yamcs_tls_verify.py Passed: 7 methods, including all optimized-mode checks
python .\functional_tests\test_yamcs_action_plugin.py Passed: 15/15
python .\functional_tests\test_yamcs_basic_auth.py Passed: 13/13
python -m pytest -p test_support.cosmos_network_guard functional_tests\test_outbound_destination_policy.py -q Passed: 57
python .\functional_tests\route_tests\test_route_blueprint_policy_inventory.py Passed: 15/15
python .\functional_tests\route_tests\test_route_unauthenticated_policy_contract.py Passed: 10/10
python .\functional_tests\route_tests\test_route_policy_test_coverage.py Passed: 4/4
python .\functional_tests\test_docs_app_surface_coverage.py Passed: 7/7; generated inventory remains current
python .\functional_tests\test_docs_site_quality.py Passed: 6/6
python -m pytest -p test_support.cosmos_network_guard functional_tests\test_action_route_cosmos_response_contract.py functional_tests\test_plugin_routes_cosmos_contract.py -q Passed: 13 before and after the port
python .\scripts\check_cosmos_response_boundaries.py --refresh Completed; manually re-reviewed only the 3 affected route owners, retaining contracts, classifications, and runtime evidence
python .\scripts\check_cosmos_response_boundaries.py Passed: 1104 owners, 430 doubles, 0 review gaps
python -m py_compile application\single_app\config.py application\single_app\functions_yamcs_operations.py application\single_app\semantic_kernel_plugins\yamcs_plugin.py application\single_app\route_backend_plugins.py functional_tests\test_yamcs_action_plugin.py functional_tests\test_yamcs_basic_auth.py functional_tests\test_yamcs_tls_verify.py Passed
git -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol --no-pager diff --check Passed
git -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol --no-pager diff --cached --check Passed, including newly added files

Network-guard pytest commands used this PowerShell setup:

$env:PYTHONPATH = "$PWD\application\single_app;$PWD\functional_tests"

Additional existing-suite limitation: python -m pytest -p test_support.cosmos_network_guard functional_tests\test_outbound_destination_policy.py functional_tests\test_action_personal_credentials.py::test_real_yamcs_sdk_handshake_and_proxy_transport_status -q produced 57 passes and 7 setup errors. Those seven cases stop before the Yamcs path because the unchanged lifecycle fixture's functions_action_catalog stub lacks build_action_planner_projection, imported by configure_action_credential_runtime(). No unrelated production/fixture changes were made to bypass it. The new focused TLS suite independently passes real-SDK status detection for all three HTTP authentication statuses across username/password, bearer, API key plus proxy Basic, proxy-only Basic, and NoAuth paths.

Documentation

  • Release notes updated, or not needed
  • Feature documentation updated, or not needed
  • Fix documentation updated, or not needed

Updated the Yamcs action reference and feature documentation, added docs/explanation/fixes/YAMCS_TLS_VERIFY_ENV_OVERRIDE_FIX.md, and added the 0.261.442 release note with non-closing issue/main-PR references.

Security checklist

  • New Flask routes include @swagger_route(security=get_auth_security())
  • Settings sent to non-admin frontends use sanitize_settings_for_user()
  • Browser JavaScript is served from local SimpleChat static assets only; no CDN-hosted JS
  • No secrets, keys, connection strings, or local-only artifacts are included

No routes, route authorization policies, settings response shapes, browser assets, destination policies, or certificate/deployment mechanisms were added or changed. Every SDK request in the TLS policy matrix retains Development's guarded HTTP adapter, including constructor-time login. The wrapper-only proxy regression preserves Requests environment handling without relaxing Development's separate forward-proxy rejection policy.

Port the verified main Yamcs TLS request policy while retaining Development destination guards and personal credential status handling. Cover guarded login, renewal, secure defaults, explicit opt-out, and failed-login cleanup with offline SDK regressions. Bump Development independently to 0.261.442.

Refs #1934. Main counterpart: #1937.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paullizer
Paul Lizer (paullizer) merged commit a47100f into Development Nov 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants