Repository navigation
Fix custom favicon persistence across instances on Development - #1936
Merged
Paul Lizer (paullizer) merged 2 commits intoNov 13, 2026
Conversation
Port favicon restoration and atomic synchronization from 48eab1c without main promotion history. Cover classic and V2 URLs with isolated runtime and browser regressions. Bump Development to 0.261.440. Refs microsoft#1932 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document why FileNotFoundError falls through to materialization rather than representing a swallowed failure. Preserve favicon behavior and advance version metadata to 0.261.441. Refs microsoft#1932 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
14 of 24 tasks
Paul Lizer (paullizer)
merged commit Nov 13, 2026
1389ee3
into
microsoft:Development
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
48eab1c86/ #1935 onto Developmentc158f26bb; no main promotion history is included.Linked issue
Refs #1932. Separate Development port of the main-targeted #1935. Neither PR is merged by this work.
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedDevelopment version:
0.261.439→0.261.441(initial port0.261.440, explanatory-comment follow-up0.261.441). No deployer changes.Testing / validation
Current review follow-up:
python -m pytest .\functional_tests\test_custom_favicon_persistence.py -q -x— 4 passed.python -m pytest .\ui_tests\test_custom_favicon_persistence.py -q -x— 2 passed, classic and V2 favicon URLs serve actual red/blue ICO bytes after settings changes and local file loss.python -m py_compile .\application\single_app\config.py .\functional_tests\test_custom_favicon_persistence.py .\ui_tests\test_custom_favicon_persistence.py— passed.python .\scripts\check_cosmos_response_boundaries.py— passed, 1104 owners, 430 doubles, 0 review gaps.git --no-pager diff --checkandgit diff --cached --check— passed.Initial port validation (production behavior is unchanged by the follow-up):
python -m pytest .\functional_tests\test_custom_favicon_persistence.py .\functional_tests\test_app_settings_store_consistency.py .\functional_tests\test_app_settings_import_boundaries.py .\functional_tests\test_v2_bootstrap_branding_and_navigation.py -q -x— 45 passed; 10 existing return-value warnings in V2 tests. Fresh real-module imports in normal/optimized Python exercise independent instance roots, startup, Redis/Cosmos/read fallback, missing/unchanged/invalid files, failed replacement cleanup, whole-file concurrent reads and real V2 shell/bootstrap URL builders.python -m pytest .\ui_tests\test_custom_favicon_persistence.py -q -x— 2 passed after capturing image decoding outside assertions. Offline temporary fixtures do not change deployed branding.python -X utf8 .\functional_tests\test_custom_logo_file_preservation_on_startup.py— passed.python -X utf8 .\functional_tests\route_tests\test_route_blueprint_policy_inventory.py— 15 passed.python -X utf8 .\functional_tests\route_tests\test_route_unauthenticated_policy_contract.py— 10 passed.python -X utf8 .\functional_tests\route_tests\test_route_policy_test_coverage.py— 4 passed.python .\functional_tests\test_docs_site_quality.py— 6 passed.python .\functional_tests\test_docs_app_surface_coverage.py— 7 passed, inventory current.python .\scripts\check_cosmos_response_boundaries.py --refresh— completed, no inventory changes. These edited modules contain no inventoried point-response owners requiring renewed review.$env:PYTHONPATH = "$PWD\application\single_app;$PWD\functional_tests"; python .\scripts\check_cosmos_response_boundaries.py --run-contracts— not completed. Started the full 251-selector owner/SDK evidence suite, then stopped the overly broad run after partial progress because this port changes no inventoried Cosmos owner or double. No full-suite pass is claimed; deterministic inventory validation and the targeted real-module runtime suites above completed.python -m py_compile .\application\single_app\app.py .\application\single_app\config.py .\functional_tests\test_custom_favicon_persistence.py .\ui_tests\test_custom_favicon_persistence.py— passed.python .\functional_tests\test_app_settings_cache_versioning.py— 1 passed, 1 failed (pre-existing Development source-marker expectation).python -m pytest .\functional_tests\test_app_settings_cache_versioning.py -q -xidentifies line 45: it expects the outdated literalapply_updates, expected_etag=expected_etag, write_guard=guard_embedding_write. Verified that the test and all three inspected settings modules are byte-identical toorigin/Development, whose settings source also lacks that literal. Left this unrelated baseline test unchanged; runtime settings and favicon fallback tests pass.Documentation
Added the Development fix note, classic/V2 branding guide note,
[BRANDING]logging inventory and release entry under0.261.441.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No production routes, authorization changes or new browser assets. Stored base64 remains server-side; existing settings sanitization and V2 projections are preserved.