Repository navigation
Fix custom favicon persistence across instances - #1935
Merged
Paul Lizer (paullizer) merged 3 commits intoNov 13, 2026
Merged
Paul Lizer (paullizer) merged 3 commits into
Paul Lizer (paullizer) merged 3 commits into
Conversation
Restore the stored favicon at startup and before static delivery, with validated atomic materialization and isolated regression coverage. Refs microsoft#1932 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
14 of 24 tasks
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issue
Fixes #1932. Related historical report: #292. Development port: #1936.
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedApplication version: 0.261.061 → 0.261.063. The original fix was implemented in 0.261.062; 0.261.063 adds the explanatory CodeQL review clarification without changing behavior. No deployer changes.
Testing / validation
python -m pytest .\functional_tests\test_custom_favicon_persistence.py .\functional_tests\test_app_settings_store_consistency.py .\functional_tests\test_app_settings_import_boundaries.py -q -x— passed, 35 tests before the comment-only review follow-up.python -m pytest .\functional_tests\test_custom_favicon_persistence.py -q -x— passed, 4 real-module cold-import cases after the review follow-up.python -m pytest .\ui_tests\test_custom_favicon_persistence.py -q -x— passed, 1 Chromium browser test against an isolated offline fixture using the real template head and favicon hook; rerun passed after the review follow-up.python .\functional_tests\test_app_settings_cache_versioning.py— passed, 2 checks.python -X utf8 .\functional_tests\test_custom_logo_file_preservation_on_startup.py— passed. Initial execution without UTF-8 failed only on Windows console emoji encoding; rerun succeeded.python -X utf8 .\functional_tests\route_tests\test_route_blueprint_policy_inventory.py— passed, 6 checks.python -X utf8 .\functional_tests\route_tests\test_route_unauthenticated_policy_contract.py— passed, 4 checks.python -X utf8 .\functional_tests\route_tests\test_route_policy_test_coverage.py— passed, 2 checks.python .\functional_tests\test_docs_site_quality.py— passed, 6 checks, including the review follow-up docs.python -m py_compile .\application\single_app\app.py .\application\single_app\config.py .\functional_tests\test_custom_favicon_persistence.py .\ui_tests\test_custom_favicon_persistence.py— passed before the follow-up;python -m py_compile .\application\single_app\config.pypassed afterward.git -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --cached --check— passed, including the review follow-up.Coverage includes real-module cold imports in normal/optimized Python, independent instance roots, Redis/Cosmos/read-fallback settings, file loss, invalid data, failed replacements, and concurrent whole-file reads. No customer/staging deployment was modified or tested. Already-open tabs may retain a cached favicon until another request/reload; Windows file-sharing failures are logged and retried on a subsequent request.
The CodeQL empty-except review finding is addressed with a comment explaining that an absent instance-local file intentionally falls through to creation from the stored favicon. The review thread was already resolved when inspected. This is not a suppression and does not change behavior.
Before the comment-only follow-up, GitHub checks for CodeQL (Python, JavaScript/TypeScript, Actions), syntax, Swagger, and CLA all passed. CI for the new head is pending. Merge-policy blocker:
enforce-branch-flowfails because repository policy requires PRs targetingmainto originate fromStaging. This main-first PR was explicitly requested; no branch-policy/workflow bypass or merge was attempted. See the branch-flow check.Documentation
Added
docs/explanation/fixes/CUSTOM_FAVICON_PERSISTENCE_FIX.md; updated the branding guide, logging tag inventory, and release notes.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No production routes were added. Raw settings remain server-side; the existing favicon file is the only generated browser asset.