Skip to content

Add a regression test for narrowing NoInfer union constituents of non-generic aliases #64969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
base: main
Choose a base branch
from
+174 −0
Open

Add a regression test for narrowing NoInfer union constituents of non-generic aliases #64969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions tsc/testdata/baselines/reference/compiler/narrowingNoInfer2.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
//// [tests/cases/compiler/narrowingNoInfer2.ts] ////

=== narrowingNoInfer2.ts ===
type U1 = NoInfer<{ kind: "a"; a: number } | { kind: "b"; b: number }> | { kind: "c" };
>U1 : Symbol(U1, Decl(narrowingNoInfer2.ts, 0, 0))
>NoInfer : Symbol(NoInfer, Decl(lib.es5.d.ts, --, --))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 0, 19))
>a : Symbol(a, Decl(narrowingNoInfer2.ts, 0, 30))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 0, 46))
>b : Symbol(b, Decl(narrowingNoInfer2.ts, 0, 57))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 0, 74))

function f1(u: U1) {
>f1 : Symbol(f1, Decl(narrowingNoInfer2.ts, 0, 87))
>u : Symbol(u, Decl(narrowingNoInfer2.ts, 2, 12))
>U1 : Symbol(U1, Decl(narrowingNoInfer2.ts, 0, 0))

if (u.kind === "a") {
>u.kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 0, 19), Decl(narrowingNoInfer2.ts, 0, 46), Decl(narrowingNoInfer2.ts, 0, 74))
>u : Symbol(u, Decl(narrowingNoInfer2.ts, 2, 12))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 0, 19), Decl(narrowingNoInfer2.ts, 0, 46), Decl(narrowingNoInfer2.ts, 0, 74))

u.a;
>u.a : Symbol(a, Decl(narrowingNoInfer2.ts, 0, 30))
>u : Symbol(u, Decl(narrowingNoInfer2.ts, 2, 12))
>a : Symbol(a, Decl(narrowingNoInfer2.ts, 0, 30))
}
}

type U2 = NoInfer<{ kind: "a"; a: number } | { kind: "b"; b: number }> | { kind: "c" };
>U2 : Symbol(U2, Decl(narrowingNoInfer2.ts, 6, 1))
>NoInfer : Symbol(NoInfer, Decl(lib.es5.d.ts, --, --))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 8, 19))
>a : Symbol(a, Decl(narrowingNoInfer2.ts, 8, 30))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 8, 46))
>b : Symbol(b, Decl(narrowingNoInfer2.ts, 8, 57))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 8, 74))

interface Box<T> {
>Box : Symbol(Box, Decl(narrowingNoInfer2.ts, 8, 87))
>T : Symbol(T, Decl(narrowingNoInfer2.ts, 10, 14))

u: U2;
>u : Symbol(Box.u, Decl(narrowingNoInfer2.ts, 10, 18))
>U2 : Symbol(U2, Decl(narrowingNoInfer2.ts, 6, 1))

t: T;
>t : Symbol(Box.t, Decl(narrowingNoInfer2.ts, 11, 10))
>T : Symbol(T, Decl(narrowingNoInfer2.ts, 10, 14))
}

declare const box: Box<string>;
>box : Symbol(box, Decl(narrowingNoInfer2.ts, 15, 13))
>Box : Symbol(Box, Decl(narrowingNoInfer2.ts, 8, 87))

box.u;
>box.u : Symbol(Box.u, Decl(narrowingNoInfer2.ts, 10, 18))
>box : Symbol(box, Decl(narrowingNoInfer2.ts, 15, 13))
>u : Symbol(Box.u, Decl(narrowingNoInfer2.ts, 10, 18))

function f2(u: U2) {
>f2 : Symbol(f2, Decl(narrowingNoInfer2.ts, 16, 6))
>u : Symbol(u, Decl(narrowingNoInfer2.ts, 18, 12))
>U2 : Symbol(U2, Decl(narrowingNoInfer2.ts, 6, 1))

if (u.kind === "a") {
>u.kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 8, 19), Decl(narrowingNoInfer2.ts, 8, 46), Decl(narrowingNoInfer2.ts, 8, 74))
>u : Symbol(u, Decl(narrowingNoInfer2.ts, 18, 12))
>kind : Symbol(kind, Decl(narrowingNoInfer2.ts, 8, 19), Decl(narrowingNoInfer2.ts, 8, 46), Decl(narrowingNoInfer2.ts, 8, 74))

u.a;
>u.a : Symbol(a, Decl(narrowingNoInfer2.ts, 8, 30))
>u : Symbol(u, Decl(narrowingNoInfer2.ts, 18, 12))
>a : Symbol(a, Decl(narrowingNoInfer2.ts, 8, 30))
}
}

71 changes: 71 additions & 0 deletions tsc/testdata/baselines/reference/compiler/narrowingNoInfer2.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
//// [tests/cases/compiler/narrowingNoInfer2.ts] ////

=== narrowingNoInfer2.ts ===
type U1 = NoInfer<{ kind: "a"; a: number } | { kind: "b"; b: number }> | { kind: "c" };
>U1 : U1
>kind : "a"
>a : number
>kind : "b"
>b : number
>kind : "c"

function f1(u: U1) {
>f1 : (u: U1) => void
>u : U1

if (u.kind === "a") {
>u.kind === "a" : boolean
>u.kind : "a" | "b" | "c"
>u : { kind: "a"; a: number; } | { kind: "b"; b: number; } | { kind: "c"; }
>kind : "a" | "b" | "c"
>"a" : "a"

u.a;
>u.a : number
>u : { kind: "a"; a: number; }
>a : number
}
}

type U2 = NoInfer<{ kind: "a"; a: number } | { kind: "b"; b: number }> | { kind: "c" };
>U2 : U2
>kind : "a"
>a : number
>kind : "b"
>b : number
>kind : "c"

interface Box<T> {
u: U2;
>u : U2

t: T;
>t : T
}

declare const box: Box<string>;
>box : Box<string>

box.u;
>box.u : U2
>box : Box<string>
>u : U2

function f2(u: U2) {
>f2 : (u: U2) => void
>u : U2

if (u.kind === "a") {
>u.kind === "a" : boolean
>u.kind : "a" | "b" | "c"
>u : { kind: "a"; a: number; } | { kind: "b"; b: number; } | { kind: "c"; }
>kind : "a" | "b" | "c"
>"a" : "a"

u.a;
>u.a : number
>u : { kind: "a"; a: number; }
>a : number
}
}

26 changes: 26 additions & 0 deletions tsc/testdata/tests/cases/compiler/narrowingNoInfer2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// @strict: true
// @noEmit: true

type U1 = NoInfer<{ kind: "a"; a: number } | { kind: "b"; b: number }> | { kind: "c" };

function f1(u: U1) {
if (u.kind === "a") {
u.a;
}
}

type U2 = NoInfer<{ kind: "a"; a: number } | { kind: "b"; b: number }> | { kind: "c" };

interface Box<T> {
u: U2;
t: T;
}

declare const box: Box<string>;
box.u;

function f2(u: U2) {
if (u.kind === "a") {
u.a;
}
}