Repository navigation
Add a regression test for narrowing NoInfer union constituents of non-generic aliases - #64969
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only additions have consistent baselines and no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds compiler regression coverage for narrowing NoInfer union constituents in non-generic aliases, without changing compiler behavior.
Changes:
- Tests discriminant narrowing directly and after accessing an alias through
Box<string>. - Adds type and symbol baselines recording the expected results.
| File | Description |
|---|---|
tsc/testdata/tests/cases/compiler/narrowingNoInfer2.ts |
Adds both narrowing scenarios under strict checking. |
tsc/testdata/baselines/reference/compiler/narrowingNoInfer2.types |
Records expected narrowed types and property types. |
tsc/testdata/baselines/reference/compiler/narrowingNoInfer2.symbols |
Records expected symbol bindings. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this missing~ coverage when playing around with: #64958 . I think the gains from that experiment are too little to justify pulling this in but the tests coverage is nice