Repository navigation
docs: clarify how the old name behaves after renaming a flow or environment - #1322
Merged
Merged
Conversation
Contributor
|
Claude finished @dangrondahl's task in 37s —— View job Follow-up review complete
Previous finding status:
New inline comments: 0 — the diff only changes doc-string text in two All previously raised findings are resolved and no new issues were found. |
gsavage
approved these changes
Nov 3, 2026
This was referenced Nov 3, 2026
dangrondahl
added a commit
to kosli-dev/docs
that referenced
this pull request
Nov 3, 2026
## Summary - Adds `implementation_guide/phase_2/plan_organizational_structure/naming_conventions/existing_flows.md` covering how to move flows already in use onto a naming convention: rename rather than recreate, how the old name behaves after a rename, rollout order, trail-name caveats, and limits. - Adds the page to the Naming Conventions group in `config/navigation.json`, after Flows and Trails. - Links from the Flows and Trails page to the new page, and fixes two relative CLI links on that page to root-relative paths. The "how the old name behaves" section mirrors the `kosli rename flow` long description from kosli-dev/cli#1322. Closes #487 ## Validation - `mint broken-links`: no broken links - `pytest tests/`: 65 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The long description on
kosli rename flowandkosli rename environmentsaid the old name stays accessible "until that name is taken by another flow/environment", without defining "taken" or saying whether reads and writes both still resolve.The new text states that:
get/listreturn the renamed object, andattest/begin trail(orsnapshotfor environments) record into it rather than auto-creating a new oneBehaviour was confirmed by reading the server's name-history lookup and auto-create logic.
Validation
make docsand checked the rendered Markdown.make lintpasses.