Skip to content

Fix "Debug artifacts after failure" PR check not checking any artifacts #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 1 commit into from
Oct 27, 2026
Merged

Fix "Debug artifacts after failure" PR check not checking any artifacts #4273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/debug-artifacts-failure-safe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ jobs:
uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
- name: Check expected artifacts exist
run: |
VERSIONS="stable-v2.20.7 default linked nightly-latest"

@mbg mbg Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Rather than having this as a local variable here, would it be easier to spot/update if it was in an env object for the step/job/workflow?

@henrymercer henrymercer Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this would be much easier to spot, and it might increase the chance of the variable being unset again.

It would also be nice to have a single source of truth for the versions, but per https://docs.github.com/en/enterprise-cloud@latest/actions/reference/workflows-and-actions/contexts#context-availability we can't use env to define a matrix and would therefore need another job to determine the matrix.

I'll leave this as is for now.

@mbg mbg Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to migrate these workflows to pr-checks/checks and generate them with sync.ts? Then we could perhaps move towards a single source of truth for the versions.

@henrymercer henrymercer Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now that we have validationJobs, I think it should be possible to autogenerate these workflows.

LANGUAGES="cpp csharp go java javascript python"
for version in $VERSIONS; do
echo "Artifacts from version $version:"
Expand Down
Loading