[henrymercer]

The "Check expected artifacts exist" step of the "Debug artifacts after failure" PR check loops over $VERSIONS, but nothing in the workflow sets it. This PR sets VERSIONS to the upload job's matrix versions, as the "Debug artifact upload" check does in debug-artifacts-safe.yml.

Risk assessment

For internal use only. Please select the risk level of this change:

• Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

• Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

• End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

• Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

• Other - The "Debug artifacts after failure" PR check will fail.

Are there any special considerations for merging or releasing this change?

• No special considerations - This change can be merged at any time.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Consider adding a changelog entry for this change.
• Confirm the readme and docs have been updated if necessary.

[Copilot]

🟢 Approval recommended

The version list matches the upload matrix and restores existing validation without changing production behavior.

No open issues 🎉

What changed in this PR

Restores artifact validation in the “Debug artifacts after failure” PR check, which previously skipped its validation loop because VERSIONS was unset.

Changes:

• Defines VERSIONS to match the upload job’s four-version matrix.
• Enables the existing per-version and per-language artifact checks.

File	Description
.github/​workflows/​debug-artifacts-failure-safe.yml	Initializes the version list used by the artifact-validation loop.

_{Review effort: Max}

[mbg]

Thanks for noticing this and addressing it! I wonder how this happened...

Just one optional suggestion; happy for this to be merged as-is.

[mbg]

Minor: Rather than having this as a local variable here, would it be easier to spot/update if it was in an env object for the step/job/workflow?

[henrymercer]

I'm not sure that this would be much easier to spot, and it might increase the chance of the variable being unset again.

It would also be nice to have a single source of truth for the versions, but per https://docs.github.com/en/enterprise-cloud@latest/actions/reference/workflows-and-actions/contexts#context-availability we can't use env to define a matrix and would therefore need another job to determine the matrix.

I'll leave this as is for now.

[mbg]

Would it make sense to migrate these workflows to pr-checks/checks and generate them with sync.ts? Then we could perhaps move towards a single source of truth for the versions.

[henrymercer]

Yes, now that we have validationJobs, I think it should be possible to autogenerate these workflows.