Skip to content

Place the bottom phantom point below the top one - #422

Open
lehni wants to merge 1 commit into
foliojs:masterfrom
lineto:fix/vertical-phantom-points
Open

lehni wants to merge 1 commit into
foliojs:masterfrom
lineto:fix/vertical-phantom-points

Conversation

@lehni

@lehni lehni commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
  • Fixes Vertical phantom points have the wrong sign #421: the bottom phantom point now sits an advance below the top one, as in the spec and HarfBuzz, so gvar deltas vary the vertical advance in the right direction
  • The test font is HarfBuzz's SourceSansVariable-Roman.modcomp.ttf without HVAR, so the advances come from the phantom points, renamed as the OFL reserves its name
  • The test expects HarfBuzz's vertical advance of 990 at wght 900, where fontkit gave 1038

- Put the bottom phantom point an advance below the top one, as the spec and HarfBuzz do, instead of above it, so gvar deltas vary the vertical advance in the right direction (foliojs#421)
- Add a test font derived from HarfBuzz's SourceSansVariable-Roman.modcomp.ttf without HVAR, so the advances come from the phantom points, renamed as the OFL reserves its name
- Expect HarfBuzz's vertical advance of 990 at wght 900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical phantom points have the wrong sign

1 participant