Repository navigation
Conversation
- Put the bottom phantom point an advance below the top one, as the spec and HarfBuzz do, instead of above it, so gvar deltas vary the vertical advance in the right direction (foliojs#421) - Add a test font derived from HarfBuzz's SourceSansVariable-Roman.modcomp.ttf without HVAR, so the advances come from the phantom points, renamed as the OFL reserves its name - Expect HarfBuzz's vertical advance of 990 at wght 900
lehni
force-pushed
the
fix/vertical-phantom-points
branch
from
November 14, 2026 14:55
1c08d08 to
47335bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.