Skip to content

Take varied composite metrics from the component that uses its metrics - #423

Open
lehni wants to merge 2 commits into
foliojs:masterfrom
lineto:fix/use-my-metrics
Open

lehni wants to merge 2 commits into
foliojs:masterfrom
lineto:fix/use-my-metrics

Conversation

@lehni

@lehni lehni commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

lehni added 2 commits October 26, 2026 11:06
- Put the bottom phantom point an advance below the top one, as the spec and HarfBuzz do, instead of above it, so gvar deltas vary the vertical advance in the right direction (foliojs#421)
- Add a test font derived from HarfBuzz's SourceSansVariable-Roman.modcomp.ttf without HVAR, so the advances come from the phantom points, renamed as the OFL reserves its name
- Expect HarfBuzz's vertical advance of 990 at wght 900
- A composite glyph's varied advances and bearings now come from the phantom points of its component with the useMyMetrics flag, as HarfBuzz does, instead of the composite's own
- Add a test with Ç from the phantom point test font, which now gets HarfBuzz's vertical advance of 990 instead of 962
@lehni
lehni force-pushed the fix/use-my-metrics branch from c54cc16 to 144a731 Compare November 14, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant