Repository navigation
fix: survive the removal of the default PulseAudio device - #584
Merged
Merged
Conversation
A query for a default device removed meanwhile fails with no info, and a server without devices names no default. Both crashed the JVM; the default is now null instead. Fixes #580
On the system's thread, a listener's device queries could not wait for PulseAudio and answered with the defaults from before the change, and the attached thread kept the JVM from ending. Changes are now queued for a daemon thread; removed listeners drop the ones still queued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeviceChangeListenerasks for the defaults: on PulseAudio's thread the query uses the name of the device just removed.NULL.getDefaultAudioCaptureDevice()/getDefaultAudioRenderDevice()now returnnull, as on macOS.WebRTC-DeviceChanges) instead of the system's thread, one change at a time and in order. Device queries from a listener then wait for PulseAudio and see the new defaults, and the PulseAudio thread no longer stays attached and keeps the JVM from ending. Changes still queued for a removed listener are dropped.DeviceBackendTestscovers it against a private PulseAudio server with virtual devices, which the Linux CI lanes now install (without autospawn).Fixes #580