Skip to content

test: write the stale partial file before the offer is accepted - #586

Merged
devopvoid merged 1 commit into
mainfrom
test/stale-part-before-accept
Nov 10, 2026
Merged

devopvoid merged 1 commit into
mainfrom
test/stale-part-before-accept

Conversation

@devopvoid

Copy link
Copy Markdown
Owner

FileTransfersTests.notResumableStartsOver wrote the stale .part file after send(), racing the receiver, which opens it once the offer is accepted. When the receiver was first, the test overwrote the open file and the received file ended up with the stale 10 KiB (seen on the linux_x86-64 lane of #584). The test now writes it in the offer handler, before accept().

The test wrote it after send(), racing the receiver, which opens the
partial file once the offer is accepted: written over an open one, the
received file ended up with the stale 10 KiB.
@devopvoid
devopvoid merged commit 54ec8d6 into main Nov 10, 2026
23 checks passed
@devopvoid
devopvoid deleted the test/stale-part-before-accept branch November 10, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant