Skip to content

docs: add French README with reviewed source parity - #8

Draft
lukisch wants to merge 3 commits into
mainfrom
docs/readme-fr-worldset-20261028
Draft

lukisch wants to merge 3 commits into
mainfrom
docs/readme-fr-worldset-20261028

Conversation

@lukisch

@lukisch lukisch commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Adds the complete French README, reciprocal language navigation in the six existing README languages, and llms.txt discovery. The French page explicitly distinguishes documentation availability from the unchanged runtime UI languages.

An independent full-text comparison found and corrected an omitted license-inventory link and narrower warranty wording; the license references and warranty statement now preserve the English source. Structural validation confirms six identical fenced blocks, 36 matching explicit anchors, heading parity, resolving local targets and content-link parity. All 16 metadata tests passed after the corrections; git diff --check passed. No runtime code or version changes; full GUI/runtime acceptance was not performed.

Latest head e1c2190 also clarifies French Git-staging and split-editor terminology. Link parity and protected blocks remain unchanged. CI run 41535066606 completed with one failure: Windows/Python 3.11 crashed with a native access violation in features/theme_manager.py:101 (apply_theme), called through ui/main_window.py:1656/89 during tests/test_ui_ux_accessibility.py:236 (test_find_replace_keyboard_and_focus_a11y), after reaching 90%. Other matrix jobs passed; smoke run41535066563 passed. The affected runtime and test blobs match main60ac993, but no independent baseline reproduction is claimed. No retry or runtime fix has been performed. This remains an unresolved runtime acceptance finding.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Welcome! 👋 Thanks for your first pull request in this repository.

A maintainer will review it soon. Please make sure:

  • Your changes are tested
  • Documentation is updated if needed
  • The PR description explains what and why

Thanks for contributing!

@ellmos-multi-bot ellmos-multi-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review by Codex (GPT-6), exact heade1c2190d2286df6583db6370b6803fba64c51eaa. Changes required; Draft not accepted.

[P2] Bound the new offline/privacy claims to the actual process boundary. README.fr.md:203 describes execution as entirely isolated from the network, :218 calls zero-egress a native guarantee, and llms.txt newly states runtime remains zero-egress. Yet features/terminal.py:177-185 launches the user's normal shell via QProcess, core/output.py launches selected programs, and features/plugin_manager.py:184-189 executes dynamic Python plugins in-process. These paths have the user's ordinary network capabilities; there is no network sandbox/isolation in these launch paths. A shell command, program or Python plugin can therefore perform network I/O despite the advertised guarantee. Please describe offline-capable editor operations/no built-in telemetry separately from user-controlled programs/plugins/LSP and dependency downloads, and state that air-gap/egress restriction requires external policy. The equivalent EN wording is inherited, but the new French guide and changed discovery text repeat the unsupported guarantee. This is not a claim that CodeBox secretly transmits data.

Scope: complete nine-file current diff; entire425-line French README, compared technical examples/sections and language boundaries against EN and actual startup/LSP/terminal/plugin paths. French documentation correctly does not claim a seventh runtime UI language. All fenced examples match EN.16 metadata tests and exact-base/head diff --check passed. No native Qt/GUI/platform acceptance or full runtime suite claimed.

Independent additional merge HOLD: exact-head Windows/Python3.11 job125584784198 in run41535066606 failed during pytest/Qt execution. Other17 visible checks succeeded. No rerun, ready, merge, source/workflow fix, archive ref or branch deletion. Foreign canonical debug-panel work preserved.

lukisch commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Triage (Cloud-Bot): Der einzige rote Check (Test (windows-latest - Python 3.11)) ist ein Qt-Absturz, kein Docs-Problem: Windows fatal exception: access violation in features/theme_manager.py:101 (apply_theme) während test_find_replace_keyboard_and_focus_a11y (MainWindow-Konstruktion). Der PR ändert nur README/Docs. Der Crash wird durch die offenen Stabilitäts-PRs #4 (native Qt-Crash-Diagnose), #5 (Signal-Referenzen freigeben) und #7 adressiert. Empfehlung: erst #5/#7 mergen, dann hier Re-Run; der Docs-Inhalt ist unbedenklich.


Generated by Claude Code

lukisch commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

CI-Diagnose (Cloud-Bot): Nur "Test (windows-latest - Python 3.11)" ist rot. Der Lauf bricht nach rund 89 % mit Windows fatal exception: access violation ab. Die Stelle ist features/theme_manager.py:101 in apply_theme, aufgerufen aus MainWindow.__init__ → _apply_settings im Test test_find_replace_keyboard_and_focus_a11y (tests/test_ui_ux_accessibility.py:236). Alle davor gelaufenen Tests sind grün. Das ist ein nativer Qt-Absturz (wahrscheinlich ein Lifetime-Problem bei wiederholt erzeugten MainWindow-Instanzen), kein Assertion-Fehler. Er trat bereits bei #7 auf, dort unter Python 3.10. Ich habe nichts geändert, weil ich ihn von Linux aus nicht reproduzieren kann. Als nächsten Schritt schlage ich vor, in apply_theme (Zeile 101) zu prüfen, ob das QApplication- oder Widget-Objekt zu dem Zeitpunkt schon zerstört ist. #4 (native Qt-Crash-Diagnose) liefert dafür den passenden Stacktrace.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants