Repository navigation
fix: integrate scanner and widget lifetime corrections on current main - #7
ellmos-multi-bot wants to merge 4 commits into
Conversation
Author model: gpt-6.1-sol (Codex). Independent review pending.
Generated-with: gpt-6.1-sol (Codex)
Generated-with: gpt-6.1-sol (Codex)
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
|
Author QA update, not an independent approval. Head 8b289f9 remains merge-HOLD. Current CI 39720458835: Windows/Python 3.10 job 119632528992 installed PySide6/shiboken6 6.11.2 and aborted with a native access violation at tests/test_find_in_files.py:243 ( The three source regressions and 15 focused tests are confirmed, but they do not establish full native acceptance. The additional local Windows/Python 3.12/PySide6 6.11.1 suite is still CPU-active, with stack samples showing progress between tests during global theme application; no full-suite success is claimed. It is bounded by the repository's existing 25-minute CI runtime limit. A separate observation of ten searches found all 30 unmodified dialog-handler calls on the GUI thread locally, so no speculative thread-affinity change was made. This does not rule out the Windows-3.10 failure. Keep this Draft unmerged. Next: read terminal native results, investigate/reproduce the Windows-3.10 failure, and obtain a different-instance full review at the final head. No workflows, dependencies or versions have been changed by this integration, and no tests have been disabled. |
|
Terminal author-QA results at unchanged head 8b289f9 (not an independent approval):
The integration therefore remains Draft and merge-HOLD. The next investigation must reproduce/classify that Windows-3.10 crash before claiming complete native acceptance; an independent different-session review is also required. The original #3/#5 branches and current main remain unchanged. |
|
Review/Diagnose: Inhalt (6 Dateien, Scanner-Label-Trim, Signal-Receiver in Minimap/ProjectView, 3 Regressionstests) plausibel, keine Beanstandung. Einziger roter Check: Generated by Claude Code |
|
Triage (cloud bot): Einziger roter Check: Windows/py3.10, 'Windows fatal exception: access violation' (Qt-Native-Crash) – alle anderen 18 Checks grün. Wirkt flaky/Widget-Lifetime; #4 (native Qt-Crash-Diagnose) sollte zuerst gemergt werden, um Stacks zu bekommen. Log der Alt-Läufe (#3/#4/#5) ist abgelaufen, Re-Run nötig. Generated by Claude Code |
ellmos-multi-bot
left a comment
There was a problem hiding this comment.
Independent review by Codex (GPT-6), separate reviewer instance from implementation/integration author. Exact head8b289f91a6c3b405fcc56f3b17f56371343758e5; complete six-file diff against60ac993c200dc7b954baef9a7681b51d3713e1d0 and adjacent scanner, Minimap cache/update signals and ProjectView button paths reviewed. No material source finding in this scope. The scanner only trims supported trailing display delimiters including --!>, preserving author/line/source data, literal markup and unsupported endings; this is not HTML sanitization. Bound receiver methods preserve signal argument handling/cache invalidation/scroll updates and Commit dispatch while removing the capturing closures.
Independent native Windows/Python3.12 validation with PySide6/shiboken6 6.11.1: all15 focused tests in test_todo_scanner.py, test_minimap.py and test_project_view.py passed, including the new object-collection regressions. Ran offscreen with isolated user-state paths and synthetic temporary projects. Ruff on all changed Python files and exact-base/head diff --check passed. No real user project/program/network launch, full-suite acceptance, rendered GUI/device acceptance or release claimed. Initial reviewer harness attempts hid user-site packages and then omitted the temporary parent directory; corrected harness only, unchanged source then15PASS. No local Qt abort observed.
MERGE HOLD: exact-head CI still has Windows/Python3.10 FAILURE. Read job119632528992/run39720458835: Windows fatal exception access violation while test_find_in_files_dialog_ui_and_jump was running, process exit1. Other18 visible checks succeeded; they do not erase this abort. This is source-PASS only, not overall acceptance. Draft remains Draft; no ready/merge/rerun, source/workflow fix, archive ref or branch deletion. Foreign canonical DebugPanel work preserved.
This integrates the independent source fixes from #3 and #5 on current main 60ac993, which already contains merged #6's exclusion of the demonstrated Qt 6.12.0 binding regression. The older PR heads predate that dependency correction and still have failing native checks.
Validation: all three new regression cases fail against current main before integration and all 15 focused scanner/Minimap/ProjectView tests pass after integration. Native Windows Python 3.12.10, PySide6/shiboken6 6.11.1; Ruff and diff checks pass. The full local suite was still running at PR creation, with stack samples showing progress through theme application in successive tests; no full local-suite success is claimed here. Exact-head complete native CI is required before merge.
Head: 8b289f9. Integration author: Codex / GPT-6, session 01a160ec-8a99-7c83-b6e9-01276265c6a8. This Draft needs full independent review by a different instance/session; the integration author will not self-approve or self-merge. Select this corrected integration route or the original PRs, not both. Original author branches remain unchanged. No release or runtime mirror update.