Repository navigation
Cap CI job run time with timeout-minutes - #2606
Merged
Merged
Conversation
None of the CI jobs set a timeout, so a hung job ran until GitHub's six-hour default. That happened in run 39815517821 when the Ubuntu package mirror used by `playwright install --with-deps` stalled. The test job gets 15 minutes rather than 10 because a slow mirror that is still working has taken up to about 11 minutes, and that should pass.
|
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3 tasks
spaceninja
added a commit
that referenced
this pull request
Oct 26, 2026
…th-deps * origin/main: Cap CI job run time with timeout-minutes (#2606)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
testjob usually takes about a minute, but roughly 1 run in 15 takes 6–11 minutes. In each case the time goes toplaywright install --with-deps, which installs system packages (mostly fonts) from Ubuntu's package mirror, and that mirror sometimes slows to 40–60 kB/s. In one run (39815517821) the download stalled completely, and because no job set a timeout, the job sat there until GitHub cancelled it at the six-hour default.This PR adds
timeout-minutesto every CI job. Since this repo is public, these runs don't use up the org's Actions minutes, but a hung job still holds one of the org's shared concurrent-job slots and delays PR feedback. Thetestjob gets 15 minutes instead of 10 so a slow mirror that is still downloading can finish rather than fail. A follow-up PR will try dropping--with-depsto avoid the apt step entirely.Screenshots
Testing