Skip to content

Say what screening a sender out does to what they already sent - #666

Merged
jeremy merged 1 commit into
mainfrom
screened-out-words
Nov 19, 2026
Merged

jeremy merged 1 commit into
mainfrom
screened-out-words

Conversation

@jeremy

@jeremy jeremy commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

What was wrong

In a Reflex eval run from basecamp/hey-native-apps (cust-unsubscribe-screens-out), the person asks their agent to "Unsubscribe me from the newsletters in my Feed." Their agent drives HEY through the app endpoint. It screened the senders out correctly, but in 2 of 3 runs it told the person that the issues already in their Feed "are still there". One earlier run called the senders "blocked" throughout, which is not a word the person can find in HEY.

screener deny's agent notes mention mail already sent only under --spam. That leaves "without --spam it stays" as the easy reading.

What HEY does

Denying a clearance destroys the examiner's postings of the sender's topics and rejects those topics. See haystack app/models/clearance/topics.rb, refresh_topics_now: postings_by_denied_petitioner_are_destroyed_for_examiner and non_spam_topics_are_rejected_if_denied_by_all_examiners. So the mail leaves the Imbox, the Feed and the Paper Trail for Screened Out, and approving the sender restores and refiles it (topics_are_activated_unseen_and_filed_for_examiner).

Change

  • screener deny's long help says that what the sender already sent leaves for Screened Out, and that approving brings it back.
  • Its agent notes ask the agent to tell the person the sender is "screened out", HEY's own words, and that their mail left with them.
  • The skill's app-mode line says the same for hey screener deny <email>.

Verification

  • make check passes.
  • scripts/skill-coverage/check.py reports the same uncovered facts as on main.
  • A Reflex play of that eval task, n=3, with hey built at this branch's head, is running. Its before and after will follow in a comment.

Summary by cubic

Fixes agents telling people that mail from screened-out senders is still in their Imbox or Feed after screener deny.

Updated screener deny's help text, agent notes, and the skill's app-mode line to state that screening a sender out moves what they already sent to the Paper Trail for Screened Out, and that approving the sender brings it back. The notes also instruct agents to use "screened out" — HEY's own term — rather than "blocked" or saying the mail is still there.

Written for commit 5086043. Summary will update on new commits.

View guided diff Turn on auto-fix

A person's agent that screened newsletter senders out told them, in 2
of 3 runs of a Reflex eval, that the issues already in their Feed were
still there, and once called the senders "blocked" throughout, a word
the person can't find in HEY. deny's notes speak of mail already sent
only under --spam, which leaves "it stays" as the easy reading.

HEY takes it out: a denied clearance destroys the examiner's postings
of the sender's topics and rejects them (haystack
app/models/clearance/topics.rb, refresh_topics_now), so they leave the
Imbox, the Feed and the Paper Trail for Screened Out, and approval
restores and refiles them. deny's long help and agent notes, and the
skill's app-mode line, now say so, and that the answer to the person
says "screened out", HEY's word.

Verified: make check green; the skill coverage check reports the same
uncovered facts as main.
@jeremy
jeremy requested a review from a team as a code owner November 19, 2026 14:58
Copilot AI balanced review requested due to automatic review settings November 19, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A maintainer must confirm Haystack’s mail removal/restoration semantics because the cited source returned 404 and app-level verification remains pending.

No open issues 🎉

What changed in this PR

Clarifies screener deny documentation so agents correctly explain what happens to existing mail and use HEY’s term “screened out.” No command behavior changes.

Changes:

  • Explain that existing mail leaves the Imbox, Feed, and Paper Trail for Screened Out, and approving the sender brings it back.
  • Update agent guidance to avoid saying senders are “blocked” or their mail remains in its previous location.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
skills/​hey/​SKILL.md Clarifies existing-mail handling and terminology for app-mode agents.
internal/​cmd/​screener_deny.go Expands command help and agent notes to explain screening out and restoration.

Review effort: Balanced

@jeremy
jeremy merged commit f6244d7 into main Nov 19, 2026
24 of 26 checks passed
@jeremy
jeremy deleted the screened-out-words branch November 19, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants