Repository navigation
Say what screening a sender out does to what they already sent - #666
Merged
Merged
Conversation
A person's agent that screened newsletter senders out told them, in 2 of 3 runs of a Reflex eval, that the issues already in their Feed were still there, and once called the senders "blocked" throughout, a word the person can't find in HEY. deny's notes speak of mail already sent only under --spam, which leaves "it stays" as the easy reading. HEY takes it out: a denied clearance destroys the examiner's postings of the sender's topics and rejects them (haystack app/models/clearance/topics.rb, refresh_topics_now), so they leave the Imbox, the Feed and the Paper Trail for Screened Out, and approval restores and refiles them. deny's long help and agent notes, and the skill's app-mode line, now say so, and that the answer to the person says "screened out", HEY's word. Verified: make check green; the skill coverage check reports the same uncovered facts as main.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
A maintainer must confirm Haystack’s mail removal/restoration semantics because the cited source returned 404 and app-level verification remains pending.
No open issues 🎉
What changed in this PR
Clarifies screener deny documentation so agents correctly explain what happens to existing mail and use HEY’s term “screened out.” No command behavior changes.
Changes:
- Explain that existing mail leaves the Imbox, Feed, and Paper Trail for Screened Out, and approving the sender brings it back.
- Update agent guidance to avoid saying senders are “blocked” or their mail remains in its previous location.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
skills/hey/SKILL.md |
Clarifies existing-mail handling and terminology for app-mode agents. |
internal/cmd/screener_deny.go |
Expands command help and agent notes to explain screening out and restoration. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
In a Reflex eval run from basecamp/hey-native-apps (
cust-unsubscribe-screens-out), the person asks their agent to "Unsubscribe me from the newsletters in my Feed." Their agent drives HEY through the app endpoint. It screened the senders out correctly, but in 2 of 3 runs it told the person that the issues already in their Feed "are still there". One earlier run called the senders "blocked" throughout, which is not a word the person can find in HEY.screener deny's agent notes mention mail already sent only under--spam. That leaves "without--spamit stays" as the easy reading.What HEY does
Denying a clearance destroys the examiner's postings of the sender's topics and rejects those topics. See haystack
app/models/clearance/topics.rb,refresh_topics_now:postings_by_denied_petitioner_are_destroyed_for_examinerandnon_spam_topics_are_rejected_if_denied_by_all_examiners. So the mail leaves the Imbox, the Feed and the Paper Trail for Screened Out, and approving the sender restores and refiles it (topics_are_activated_unseen_and_filed_for_examiner).Change
screener deny's long help says that what the sender already sent leaves for Screened Out, and that approving brings it back.hey screener deny <email>.Verification
make checkpasses.scripts/skill-coverage/check.pyreports the same uncovered facts as onmain.Summary by cubic
Fixes agents telling people that mail from screened-out senders is still in their Imbox or Feed after
screener deny.Updated
screener deny's help text, agent notes, and the skill's app-mode line to state that screening a sender out moves what they already sent to the Paper Trail for Screened Out, and that approving the sender brings it back. The notes also instruct agents to use "screened out" — HEY's own term — rather than "blocked" or saying the mail is still there.Written for commit 5086043. Summary will update on new commits.