Repository navigation
Conversation
#666 added a sentence to the HEY app section that took SKILL.md to 17,597 bytes, over the 17,408 TestHeySkillStaysDiscoveryFirstAndFocused allows, so Tests and Race Detection have failed on main since. Says the same in fewer words: what a screened-out sender already sent goes with them to Screened Out, and the person hears "screened out", never "blocked" or that their mail is still there. Drops the opening line that restated the frontmatter's description, and folds the command-reference sentence into one. Now 17,319 bytes. Verified: make check green.
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are identified for the skill-documentation trim.
No open issues 🎉
What changed in this PR
Reduces the embedded HEY agent skill to 17,319 bytes, below its unchanged 17,408-byte limit, addressing the size-check failures introduced by #666.
Changes:
- Removes the introductory line that duplicates the frontmatter.
- Condenses command-reference guidance while keeping the binary’s help as the source of truth.
- Shortens screening guidance while preserving where existing mail goes and HEY’s “screened out” terminology.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
skills/hey/SKILL.md |
Trims redundant wording to meet the size budget while preserving agent guidance. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestsandRace Detection, both required, have failed onmainsince #666:TestHeySkillStaysDiscoveryFirstAndFocusedcapsskills/hey/SKILL.mdat 17,408 bytes (embed_test.go), and #666's sentence in the HEY app section took it to 17,597. Every PR since needs an admin merge (#667 did).What changes, all in
skills/hey/SKILL.md(now 17,319 bytes):hey screener deny's agent notes keep the longer version.description.The budget stays at 17 KiB; this doesn't raise it.
Verified:
make checkgreen locally (fmt, vet, lint, unit tests, skill sync, surface, release lockstep).Summary by cubic
Brings
skills/hey/SKILL.mdback under its 17,408-byte budget after #666 pushed it to 17,597 bytes, which has been failing requiredTestsandRace Detectiononmainsince.descriptionand folds the command-reference sentence into one.Written for commit 689e272. Summary will update on new commits.