Skip to content

Bring the skill back under its size budget - #669

Open
jeremy wants to merge 1 commit into
mainfrom
fix/skill-size-budget
Open

jeremy wants to merge 1 commit into
mainfrom
fix/skill-size-budget

Conversation

@jeremy

@jeremy jeremy commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Tests and Race Detection, both required, have failed on main since #666: TestHeySkillStaysDiscoveryFirstAndFocused caps skills/hey/SKILL.md at 17,408 bytes (embed_test.go), and #666's sentence in the HEY app section took it to 17,597. Every PR since needs an admin merge (#667 did).

What changes, all in skills/hey/SKILL.md (now 17,319 bytes):

  • The Say what screening a sender out does to what they already sent #666 sentence, shorter, same rule: what a screened-out sender already sent goes with them to Screened Out; tell the person they are screened out, HEY's words, never "blocked" or that their mail is still there. hey screener deny's agent notes keep the longer version.
  • Drops the line under the title that restated the frontmatter's description.
  • Folds the command-reference sentence into one. It still names the binary's help as the source of truth, which the test requires.

The budget stays at 17 KiB; this doesn't raise it.

Verified: make check green locally (fmt, vet, lint, unit tests, skill sync, surface, release lockstep).


Summary by cubic

Brings skills/hey/SKILL.md back under its 17,408-byte budget after #666 pushed it to 17,597 bytes, which has been failing required Tests and Race Detection on main since.

  • Shortens the Say what screening a sender out does to what they already sent #666 sentence to say the same thing: a screened-out sender's existing mail goes to Screened Out, and the person is told they are screened out, never "blocked".
  • Removes the opening line that restated the frontmatter's description and folds the command-reference sentence into one.
  • Keeps the budget at 17 KiB; the file is now 17,319 bytes.

Written for commit 689e272. Summary will update on new commits.

View guided diff Turn on auto-fix

#666 added a sentence to the HEY app section that took SKILL.md to 17,597
bytes, over the 17,408 TestHeySkillStaysDiscoveryFirstAndFocused allows,
so Tests and Race Detection have failed on main since.

Says the same in fewer words: what a screened-out sender already sent
goes with them to Screened Out, and the person hears "screened out",
never "blocked" or that their mail is still there. Drops the opening
line that restated the frontmatter's description, and folds the
command-reference sentence into one. Now 17,319 bytes.

Verified: make check green.
@jeremy
jeremy requested a review from a team as a code owner November 21, 2026 00:28
Copilot AI balanced review requested due to automatic review settings November 21, 2026 00:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are identified for the skill-documentation trim.

No open issues 🎉

What changed in this PR

Reduces the embedded HEY agent skill to 17,319 bytes, below its unchanged 17,408-byte limit, addressing the size-check failures introduced by #666.

Changes:

  • Removes the introductory line that duplicates the frontmatter.
  • Condenses command-reference guidance while keeping the binary’s help as the source of truth.
  • Shortens screening guidance while preserving where existing mail goes and HEY’s “screened out” terminology.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
skills/​hey/​SKILL.md Trims redundant wording to meet the size budget while preserving agent guidance.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants